Issue 14230010: [chromedriver] Fix issue of cache id in JS.

Issue 14230010: [chromedriver] Fix issue of cache id in JS. (Closed)

Created:
7 years, 8 months ago by chrisgao (Use stgao instead)

Modified:
7 years, 8 months ago

Reviewers:
kkania

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix issue of cache id in JS. Also enable three passed java tests. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194743

Patch Set 2 : Address comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+123 lines, -104 lines)			Patch
M	chrome/test/chromedriver/js/call_function.js	View	1	5 chunks	+58 lines, -53 lines	0 comments	Download
M	chrome/test/chromedriver/js/call_function_test.html	View	1	2 chunks	+65 lines, -48 lines	0 comments	Download
M	chrome/test/chromedriver/test_expectations	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kkania

lgtm https://codereview.chromium.org/14230010/diff/9001/chrome/test/chromedriver/js/call_function.js File chrome/test/chromedriver/js/call_function.js (right): https://codereview.chromium.org/14230010/diff/9001/chrome/test/chromedriver/js/call_function.js#newcode172 chrome/test/chromedriver/js/call_function.js:172: var cache = getPageCache(document); remove document? https://codereview.chromium.org/14230010/diff/9001/chrome/test/chromedriver/js/call_function_test.html File ...

7 years, 8 months ago (2013-04-17 21:04:28 UTC) #2

chrisgao (Use stgao instead)

https://codereview.chromium.org/14230010/diff/9001/chrome/test/chromedriver/js/call_function.js File chrome/test/chromedriver/js/call_function.js (right): https://codereview.chromium.org/14230010/diff/9001/chrome/test/chromedriver/js/call_function.js#newcode172 chrome/test/chromedriver/js/call_function.js:172: var cache = getPageCache(document); On 2013/04/17 21:04:28, kkania wrote: ...

7 years, 8 months ago (2013-04-17 22:17:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14230010/15001

7 years, 8 months ago (2013-04-18 00:37:13 UTC) #4

Message was sent while issue was closed.

Change committed as 194743

Expand Messages | Collapse Messages