Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: cc/resources/tile_manager.cc

Issue 14230007: cc: Do GatherPixelRefs from skia at record time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture_unittest.cc ('k') | cc/test/fake_content_layer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/tile_manager.cc
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc
index 5e42642f050e4ce3032c944940a2fd55e63cb86a..3fe431d5b315459d95400e6fedb7c7670cabfb5f 100644
--- a/cc/resources/tile_manager.cc
+++ b/cc/resources/tile_manager.cc
@@ -686,15 +686,21 @@ void TileManager::AnalyzeTile(Tile* tile) {
}
void TileManager::GatherPixelRefsForTile(Tile* tile) {
+ // TODO(vmpstr): Remove this function and pending_pixel_refs
+ // when reveman's improvements to worker pool go in.
TRACE_EVENT0("cc", "TileManager::GatherPixelRefsForTile");
ManagedTileState& managed_tile_state = tile->managed_state();
if (managed_tile_state.need_to_gather_pixel_refs) {
base::TimeTicks start_time =
rendering_stats_instrumentation_->StartRecording();
- tile->picture_pile()->GatherPixelRefs(
- tile->content_rect_,
- tile->contents_scale_,
- managed_tile_state.pending_pixel_refs);
+ for (PicturePileImpl::PixelRefIterator pixel_ref_iter(
+ tile->content_rect(),
+ tile->contents_scale(),
+ tile->picture_pile());
+ pixel_ref_iter;
+ ++pixel_ref_iter) {
+ managed_tile_state.pending_pixel_refs.push_back(*pixel_ref_iter);
+ }
managed_tile_state.need_to_gather_pixel_refs = false;
base::TimeDelta duration =
rendering_stats_instrumentation_->EndRecording(start_time);
« no previous file with comments | « cc/resources/picture_unittest.cc ('k') | cc/test/fake_content_layer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698