Remove all code for chrome.experimental.speechInput extension API

Remove all code for chrome.experimental.speechInput extension API

BUG=230740
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196034

[Matt Perry, 2013-04-17 20:27:39]

lgtm

https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:4163: <int value="442"
label="DEVELOPERPRIVATE_LOADUNPACKEDCROS"/>
did you mean to add these?

[方觉(Fang Jue), 2013-04-17 23:20:55]

On 2013/04/17 20:27:39, Matt Perry wrote:
> lgtm
> 
>
https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
> tools/metrics/histograms/histograms.xml:4163: <int value="442"
> label="DEVELOPERPRIVATE_LOADUNPACKEDCROS"/>
> did you mean to add these?

No. The file was updated by running update_extension_functions.py.
By the way, kalman said that I didn't need to update this file in another patch
(https://codereview.chromium.org/14027005/ ). So should I update the xml?

[Matt Perry, 2013-04-17 23:29:03]

On 2013/04/17 23:20:55, 方觉(Fang Jue) wrote:
> On 2013/04/17 20:27:39, Matt Perry wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
> > File tools/metrics/histograms/histograms.xml (right):
> > 
> >
>
https://codereview.chromium.org/14230005/diff/1/tools/metrics/histograms/hist...
> > tools/metrics/histograms/histograms.xml:4163: <int value="442"
> > label="DEVELOPERPRIVATE_LOADUNPACKEDCROS"/>
> > did you mean to add these?
> 
> No. The file was updated by running update_extension_functions.py.
> By the way, kalman said that I didn't need to update this file in another
patch
> (https://codereview.chromium.org/14027005/ ). So should I update the xml?

I'm not sure. Please double-check with kalman.

[方觉(Fang Jue), 2013-04-17 23:42:38]

+kalman: could you please explain something more about histogram.xml (or point
to me docs, if any) and should I update it in this patch?

[not at google - send to devlin, 2013-04-18 03:25:02]

I'm out of my depth, looks like histograms.xml has been open-sourced - but I
have no idea why it has / needs to have those extension function enums embedded
in them. +isherman?

[方觉(Fang Jue), 2013-04-18 10:03:54]

Adding OWNERS for review.
+Miranda Callahan: Please take a look at profile_dependency_manager.
+hans: Please take a look at c/b/speech.
+sky: Please take a look at gyps, chrome/common/chrome_notification_types.h and
chrome/common/extensions_api_resources.grd.
+Ilya Sherman: Should I update histogram.xml after modifying
extension_function_histogram_value.h?

[hans, 2013-04-18 10:09:38]

On 2013/04/18 10:03:54, 方觉(Fang Jue) wrote:
> Adding OWNERS for review.
> +hans: Please take a look at c/b/speech.

lgtm; if it builds, i'm happy :)

[Ilya Sherman, 2013-04-18 16:48:52]

histograms.xml LGTM

On 2013/04/18 03:25:02, kalman wrote:
> I'm out of my depth, looks like histograms.xml has been open-sourced - but I
> have no idea why it has / needs to have those extension function enums
embedded
> in them. +isherman?

There's a histogram [1] that logs which extension function was called.  In order
to be able to interpret that data, the histograms.xml enum needs to be updated
as new functions are added.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

[not at google - send to devlin, 2013-04-18 16:52:23]

On 2013/04/18 16:48:52, Ilya Sherman wrote:
> histograms.xml LGTM
> 
> On 2013/04/18 03:25:02, kalman wrote:
> > I'm out of my depth, looks like histograms.xml has been open-sourced - but I
> > have no idea why it has / needs to have those extension function enums
> embedded
> > in them. +isherman?
> 
> There's a histogram [1] that logs which extension function was called.  In
order
> to be able to interpret that data, the histograms.xml enum needs to be updated
> as new functions are added.
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

Oh, I was under the impression that UMA_HISTOGRAM_ENUMERATION can pull that data
from the C++ type.

[Ilya Sherman, 2013-04-18 16:57:10]

On 2013/04/18 16:52:23, kalman wrote:
> On 2013/04/18 16:48:52, Ilya Sherman wrote:
> > histograms.xml LGTM
> > 
> > On 2013/04/18 03:25:02, kalman wrote:
> > > I'm out of my depth, looks like histograms.xml has been open-sourced - but
I
> > > have no idea why it has / needs to have those extension function enums
> > embedded
> > > in them. +isherman?
> > 
> > There's a histogram [1] that logs which extension function was called.  In
> order
> > to be able to interpret that data, the histograms.xml enum needs to be
updated
> > as new functions are added.
> > 
> > [1]
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> 
> Oh, I was under the impression that UMA_HISTOGRAM_ENUMERATION can pull that
data
> from the C++ type.

UMA_HISTOGRAM_ENUMERATION just logs an integer corresponding to the enum value. 
So, the effect of adding the mapping in histograms.xml is to give human-readable
names on the dashboard.

[not at google - send to devlin, 2013-04-18 17:03:59]

On 2013/04/18 16:57:10, Ilya Sherman wrote:
> On 2013/04/18 16:52:23, kalman wrote:
> > On 2013/04/18 16:48:52, Ilya Sherman wrote:
> > > histograms.xml LGTM
> > > 
> > > On 2013/04/18 03:25:02, kalman wrote:
> > > > I'm out of my depth, looks like histograms.xml has been open-sourced -
but
> I
> > > > have no idea why it has / needs to have those extension function enums
> > > embedded
> > > > in them. +isherman?
> > > 
> > > There's a histogram [1] that logs which extension function was called.  In
> > order
> > > to be able to interpret that data, the histograms.xml enum needs to be
> updated
> > > as new functions are added.
> > > 
> > > [1]
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> > 
> > Oh, I was under the impression that UMA_HISTOGRAM_ENUMERATION can pull that
> data
> > from the C++ type.
> 
> UMA_HISTOGRAM_ENUMERATION just logs an integer corresponding to the enum
value. 
> So, the effect of adding the mapping in histograms.xml is to give
human-readable
> names on the dashboard.

So every time an enum is used in UMA_HISTOGRAM_ENUMERATION we need to make sure
that it's always up to date? I guess that's leading to problems right here where
people aren't updating it.

We should add a presubmit for
chrome/browser/extensions/extension_function_histogram_value.h then. This is
like a mini version of the issues we had with the docs generation.

(Ideally it could be done automatically

[not at google - send to devlin, 2013-04-18 17:09:20]

Filed http://crbug.com/233224.

Now, for that automatic generation stuff... eh.

[not at google - send to devlin, 2013-04-18 17:09:38]

On 2013/04/18 17:09:20, kalman wrote:
> Filed http://crbug.com/233224.
> 
> Now, for that automatic generation stuff... eh.

Anyhow, don't consider me blocking this CL.

[Ilya Sherman, 2013-04-18 17:10:25]

On 2013/04/18 17:03:59, kalman wrote:
> On 2013/04/18 16:57:10, Ilya Sherman wrote:
> > On 2013/04/18 16:52:23, kalman wrote:
> > > On 2013/04/18 16:48:52, Ilya Sherman wrote:
> > > > histograms.xml LGTM
> > > > 
> > > > On 2013/04/18 03:25:02, kalman wrote:
> > > > > I'm out of my depth, looks like histograms.xml has been open-sourced -
> but
> > I
> > > > > have no idea why it has / needs to have those extension function enums
> > > > embedded
> > > > > in them. +isherman?
> > > > 
> > > > There's a histogram [1] that logs which extension function was called. 
In
> > > order
> > > > to be able to interpret that data, the histograms.xml enum needs to be
> > updated
> > > > as new functions are added.
> > > > 
> > > > [1]
> > > >
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> > > 
> > > Oh, I was under the impression that UMA_HISTOGRAM_ENUMERATION can pull
that
> > data
> > > from the C++ type.
> > 
> > UMA_HISTOGRAM_ENUMERATION just logs an integer corresponding to the enum
> value. 
> > So, the effect of adding the mapping in histograms.xml is to give
> human-readable
> > names on the dashboard.
> 
> So every time an enum is used in UMA_HISTOGRAM_ENUMERATION we need to make
sure
> that it's always up to date? I guess that's leading to problems right here
where
> people aren't updating it.

It's not a problem to only update histograms.xml periodically.  Once the mapping
is present in the XML file, the dashboard will be able to decode all the
corresponding data, including data uploaded before histograms.xml was updated.

OTOH, until histograms.xml is updated, the dashboard will just show the raw
backing integer constants, rather than the nice named constants.

> We should add a presubmit for
> chrome/browser/extensions/extension_function_histogram_value.h then. This is
> like a mini version of the issues we had with the docs generation.
> 
> (Ideally it could be done automatically

The script that updates this enumeration in histograms.xml should be safe to run
automatically; so as long as there's a way to hook it up as part of the
presubmit, we should be good to go.

[jar (doing other things), 2013-04-18 18:20:04]

It is not a "big" problem if you forget to update the enums.

When you go to the histogram's page, you'll see numbers, instead of names... and
you'll realize you need to update.

Once you update, all data (old and new) will be visible.

On 2013/04/18 17:03:59, kalman wrote:
> On 2013/04/18 16:57:10, Ilya Sherman wrote:
> > On 2013/04/18 16:52:23, kalman wrote:
> > > On 2013/04/18 16:48:52, Ilya Sherman wrote:
> > > > histograms.xml LGTM
> > > > 
> > > > On 2013/04/18 03:25:02, kalman wrote:
> > > > > I'm out of my depth, looks like histograms.xml has been open-sourced -
> but
> > I
> > > > > have no idea why it has / needs to have those extension function enums
> > > > embedded
> > > > > in them. +isherman?
> > > > 
> > > > There's a histogram [1] that logs which extension function was called. 
In
> > > order
> > > > to be able to interpret that data, the histograms.xml enum needs to be
> > updated
> > > > as new functions are added.
> > > > 
> > > > [1]
> > > >
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
> > > 
> > > Oh, I was under the impression that UMA_HISTOGRAM_ENUMERATION can pull
that
> > data
> > > from the C++ type.
> > 
> > UMA_HISTOGRAM_ENUMERATION just logs an integer corresponding to the enum
> value. 
> > So, the effect of adding the mapping in histograms.xml is to give
> human-readable
> > names on the dashboard.
> 
> So every time an enum is used in UMA_HISTOGRAM_ENUMERATION we need to make
sure
> that it's always up to date? I guess that's leading to problems right here
where
> people aren't updating it.
> 
> We should add a presubmit for
> chrome/browser/extensions/extension_function_histogram_value.h then. This is
> like a mini version of the issues we had with the docs generation.
> 
> (Ideally it could be done automatically

[not at google - send to devlin, 2013-04-18 19:30:10]

On 2013/04/18 18:20:04, jar wrote:
> It is not a "big" problem if you forget to update the enums.
> 
> When you go to the histogram's page, you'll see numbers, instead of names...
and
> you'll realize you need to update.
> 
> Once you update, all data (old and new) will be visible.
> 

It's a problem due to situations like this, where we end up with patches forced
to make unrelated changes.

[方觉(Fang Jue), 2013-04-22 22:47:59]

On 2013/04/18 10:03:54, 方觉(Fang Jue) wrote:
> Adding OWNERS for review.
> +Miranda Callahan: Please take a look at profile_dependency_manager.cc
> +sky: Please take a look at gyps, chrome/common/chrome_notification_types.h
and
> chrome/common/extensions_api_resources.grd.

ping.

[sky, 2013-04-22 23:30:06]

Don't you need to update chrome_tests.gypi ?

[方觉(Fang Jue), 2013-04-22 23:34:29]

On 2013/04/22 23:30:06, sky wrote:
> Don't you need to update chrome_tests.gypi ?

Oh, sorry. It was somehow missing from the second patchset. I'll upload a third
patchset with that in a minute.

[Miranda Callahan, 2013-04-23 06:56:40]

profile_dependency_manager.cc LGTM.

On 2013/04/22 23:34:29, 方觉(Fang Jue) wrote:
> On 2013/04/22 23:30:06, sky wrote:
> > Don't you need to update chrome_tests.gypi ?
> 
> Oh, sorry. It was somehow missing from the second patchset. I'll upload a
third
> patchset with that in a minute.

[sky, 2013-04-23 15:08:40]

LGTM

[commit-bot: I haz the power, 2013-04-23 23:35:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/14230005/41001

[commit-bot: I haz the power, 2013-04-23 23:35:56]

Failed to apply patch for tools/metrics/histograms/histograms.xml:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file tools/metrics/histograms/histograms.xml
  Hunk #1 succeeded at 4571 (offset 7 lines).
  Hunk #2 succeeded at 4726 (offset 7 lines).
  Hunk #3 succeeded at 4753 (offset 7 lines).
  Hunk #4 succeeded at 4918 (offset 7 lines).
  Hunk #5 succeeded at 4928 (offset 7 lines).
  Hunk #6 FAILED at 4975.
  1 out of 6 hunks FAILED -- saving rejects to file
tools/metrics/histograms/histograms.xml.rej

Patch:       tools/metrics/histograms/histograms.xml
Index: tools/metrics/histograms/histograms.xml
===================================================================
--- tools/metrics/histograms/histograms.xml	(revision 195413)
+++ tools/metrics/histograms/histograms.xml	(working copy)
@@ -4564,7 +4564,7 @@
   <int value="25" label="TTS_SPEAK"/>
   <int value="26" label="WALLPAPERPRIVATE_RESTOREMINIMIZEDWINDOWS"/>
   <int value="27" label="BROWSINGDATA_REMOVEHISTORY"/>
-  <int value="28" label="FILEBROWSERPRIVATE_ISFULLSCREEN"/>
+  <int value="28" label="DELETED_FILEBROWSERPRIVATE_ISFULLSCREEN"/>
   <int value="29" label="AUTOTESTPRIVATE_LOGOUT"/>
   <int value="30" label="EXPERIMENTAL_HISTORY_GETMOSTVISITED"/>
   <int value="31" label="BLUETOOTH_DISCONNECT"/>
@@ -4719,7 +4719,7 @@
   <int value="180" label="RUNTIME_GETBACKGROUNDPAGE"/>
   <int value="181" label="EXPERIMENTAL_RECORD_REPLAYURLS"/>
   <int value="182" label="WEBSTOREPRIVATE_COMPLETEINSTALL"/>
-  <int value="183" label="EXPERIMENTAL_SPEECHINPUT_START"/>
+  <int value="183" label="DELETED_EXPERIMENTAL_SPEECHINPUT_START"/>
   <int value="184" label="COOKIES_GETALL"/>
   <int value="185" label="DOWNLOADS_GETFILEICON"/>
   <int value="186" label="PAGEACTION_GETTITLE"/>
@@ -4746,7 +4746,7 @@
   <int value="207" label="WEBSTOREPRIVATE_BEGININSTALLWITHMANIFEST3"/>
   <int value="208" label="WALLPAPERPRIVATE_SETWALLPAPER"/>
   <int value="209" label="USB_CONTROLTRANSFER"/>
-  <int value="210" label="EXPERIMENTAL_SPEECHINPUT_STOP"/>
+  <int value="210" label="DELETED_EXPERIMENTAL_SPEECHINPUT_STOP"/>
   <int value="211" label="USB_BULKTRANSFER"/>
   <int value="212" label="FILEBROWSERPRIVATE_GETVOLUMEMETADATA"/>
   <int value="213" label="PAGECAPTURE_SAVEASMHTML"/>
@@ -4911,7 +4911,7 @@
   <int value="372" label="BROWSINGDATA_REMOVECACHE"/>
   <int value="373" label="BOOKMARKMANAGERPRIVATE_RECORDLAUNCH"/>
   <int value="374" label="BROWSERACTION_DISABLE"/>
-  <int value="375" label="EXPERIMENTAL_SPEECHINPUT_ISRECORDING"/>
+  <int value="375" label="DELETED_EXPERIMENTAL_SPEECHINPUT_ISRECORDING"/>
   <int value="376" label="APP_WINDOW_CREATE"/>
   <int value="377" label="RUNTIME_RELOAD"/>
   <int value="378" label="EXPERIMENTAL_POWER_REQUESTKEEPAWAKE"/>
@@ -4921,7 +4921,7 @@
   <int value="382" label="EVENTS_REMOVERULES"/>
   <int value="383" label="DOWNLOADS_DOWNLOAD"/>
   <int value="384" label="WINDOWS_GETALL"/>
-  <int value="385" label="FILEBROWSERPRIVATE_TOGGLEFULLSCREEN"/>
+  <int value="385" label="DELETED_FILEBROWSERPRIVATE_TOGGLEFULLSCREEN"/>
   <int value="386" label="APP_CURRENTWINDOWINTERNAL_RESTORE"/>
   <int value="387" label="WEBSOCKETPROXYPRIVATE_GETPASSPORTFORTCP"/>
   <int value="388" label="PAGEACTION_HIDE"/>
@@ -4975,6 +4975,18 @@
   <int value="436" label="SYNCFILESYSTEM_GETFILESYNCSTATUSES"/>
   <int value="437" label="MEDIAGALLERIESPRIVATE_GETHANDLERS"/>
   <int value="438" label="WALLPAPERPRIVATE_RESETWALLPAPER"/>
+  <int value="439" label="DEVELOPERPRIVATE_PERMISSIONS"/>
+  <int value="440" label="WEBSTOREPRIVATE_ENABLEAPPLAUNCHER"/>
+  <int value="441" label="APP_CURRENTWINDOWINTERNAL_FULLSCREEN"/>
+  <int value="442" label="DEVELOPERPRIVATE_LOADUNPACKEDCROS"/>
+  <int value="443" label="NETWORKINGPRIVATE_REQUESTNETWORKSCAN"/>
+  <int value="444" label="ENTERPRISE_PLATFORMKEYSPRIVATE_CHALLENGEMACHINEKEY"/>
+  <int value="445" label="ENTERPRISE_PLATFORMKEYSPRIVATE_CHALLENGEUSERKEY"/>
+  <int value="446" label="DEVELOPERPRIVATE_LOADPROJECTTOSYNCFS"/>
+  <int value="447" label="DEVELOPERPRIVATE_GETPROJECTSINFO"/>
+  <int value="448" label="DEVELOPERPRIVATE_LOADPROJECT"/>
+  <int value="449" label="COMMANDLINEPRIVATE_HASSWITCH"/>
+  <int value="450" label="NETWORKINGPRIVATE_GETMANAGEDPROPERTIES"/>
 </enum>
 
 <enum name="FallbackSSLVersion" type="int">

[commit-bot: I haz the power, 2013-04-23 23:41:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/14230005/46001

[commit-bot: I haz the power, 2013-04-24 02:26:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/14230005/46001

[commit-bot: I haz the power, 2013-04-24 04:50:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/14230005/46001

[commit-bot: I haz the power, 2013-04-24 04:51:06]

Presubmit check for 14230005-46001 failed and returned exit status 1.

INFO:root:Found 8 file(s).

..ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
ERROR:root:File system is offline, cannot read docs/templates/public/
.
----------------------------------------------------------------------
Ran 3 tests in 0.017s

OK
Rendering 0 explicit files...
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1368, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1180, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1097, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 155, in CheckChangeOnCommit
  File "<string>", line 147, in _CheckChange
NameError: global name '_CheckVersions' is not defined

[commit-bot: I haz the power, 2013-04-24 04:52:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fangjue23303@gmail.com/14230005/46001

[commit-bot: I haz the power, 2013-04-24 05:00:29]

Change committed as 196034