Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: build/common.gypi

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unneeded include Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/win_util.h ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 63fce9c159fed5c89a2e80578a02ed527f3c022d..b39280f90ab52fdd0e65fec2c3feb7f917a9e9b9 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3160,6 +3160,7 @@
'_SCL_SECURE_NO_DEPRECATE',
],
'msvs_disabled_warnings': [
+ # forcing value to bool 'true' or 'false' (performance warning)
4800,
],
'msvs_settings': {
@@ -5636,7 +5637,7 @@
# it's enabled. This will generally only be true for system-level
# installed Express users.
'msvs_disabled_warnings': [
- 4702,
+ 4702, # unreachable code
],
}],
],
@@ -5720,6 +5721,10 @@
# should work through these at some point -- they may be removed from
# the RTM release in the /W4 set.
4456, 4457, 4458, 4459,
+
+ # TODO(brucedawson): http://crbug.com/554200 4312 is a VS
+ # 2015 64-bit warning for integer to larger pointer
+ 4312,
],
'msvs_settings': {
'VCCLCompilerTool': {
« no previous file with comments | « base/win/win_util.h ('k') | chrome/app/chrome_watcher_client_unittest_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698