[Ozone] Enables overlay render format setting path and by default use UYVY

content/common/gpu/media/vaapi_video_encode_accelerator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/vaapi_video_encode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 564 matching lines @@
 
   DCHECK(!current_encode_job_);
   current_encode_job_.reset(new EncodeJob());
 
   if (!vaapi_wrapper_->CreateCodedBuffer(output_buffer_byte_size_,
                                          &current_encode_job_->coded_buffer)) {
     NOTIFY_ERROR(kPlatformFailureError, "Failed creating coded buffer");
     return false;
   }
 
-  current_encode_job_->input_surface = new VASurface(
-      available_va_surface_ids_.back(), coded_size_, va_surface_release_cb_);
+  current_encode_job_->input_surface =
+      new VASurface(available_va_surface_ids_.back(), coded_size_,
+                    VA_RT_FORMAT_YUV420, va_surface_release_cb_);

[Pawel Osciak, 2015/11/05 10:23:51]

We shouldn't be hardcoding the format in multiple places like this, as I
mentioned previously. It's easy to not change this later, or have some other
mismatch somewhere.

We'd have to use a separate struct instead of VASurfaceID vector in VaapiWrapper
for this though. But since the surface set is tied to current VaapiWrapper
state, I'm ok adding a surface_format_ member to VaapiWrapper and an ability to
query for it instead.

So VaapiWrapper::CreateSurfaces() would create surfaces and store the format of
the created surfaces in VaapiWrapper. Then we could query the wrapper for the
current format here and in other places.

[william.xie1, 2015/11/06 06:56:14]

Done.

   available_va_surface_ids_.pop_back();
 
-  current_encode_job_->recon_surface = new VASurface(
-      available_va_surface_ids_.back(), coded_size_, va_surface_release_cb_);
+  current_encode_job_->recon_surface =
+      new VASurface(available_va_surface_ids_.back(), coded_size_,
+                    VA_RT_FORMAT_YUV420, va_surface_release_cb_);
   available_va_surface_ids_.pop_back();
 
   // Reference surfaces are needed until the job is done, but they get
   // removed from ref_pic_list0_ when it's full at the end of job submission.
   // Keep refs to them along with the job and only release after sync.
   current_encode_job_->reference_surfaces = ref_pic_list0_;
 
   return true;
 }
 
@@ skipping 448 matching lines @@
 }
 
 VaapiVideoEncodeAccelerator::EncodeJob::EncodeJob()
     : coded_buffer(VA_INVALID_ID), keyframe(false) {
 }
 
 VaapiVideoEncodeAccelerator::EncodeJob::~EncodeJob() {
 }
 
 }  // namespace content