[Ozone] Enables overlay render format setting path and by default use UYVY

content/common/gpu/media/vaapi_drm_picture.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_descriptor_posix.h"
 #include "content/common/gpu/media/va_surface.h"
 #include "content/common/gpu/media/vaapi_drm_picture.h"
 #include "content/common/gpu/media/vaapi_wrapper.h"
 #include "third_party/libva/va/drm/va_drm.h"
 #include "third_party/libva/va/va.h"
 #include "third_party/libva/va/va_drmcommon.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_image_ozone_native_pixmap.h"
 #include "ui/gl/scoped_binders.h"
 #include "ui/ozone/public/native_pixmap.h"
 #include "ui/ozone/public/ozone_platform.h"
 #include "ui/ozone/public/surface_factory_ozone.h"
 
 namespace content {
 
+// Format for storing the video decoded pictures.

[Pawel Osciak, 2015/11/05 10:23:51]

Please correct this documentation, explaining why this uses BGRX, as per my
previous comment on earlier patchset.

[william.xie1, 2015/11/06 06:56:14]

Done.

+const gfx::BufferFormat kPictureForGLImageFormat = gfx::BufferFormat::BGRX_8888;
+
+uint32_t BufferFormatToVAFourCC(gfx::BufferFormat fmt) {

[Pawel Osciak, 2015/11/05 10:23:51]

Please put these functions and the constant in an anonymous namespace.

[william.xie1, 2015/11/06 06:56:14]

Done.

+  switch (fmt) {
+    case gfx::BufferFormat::BGRX_8888:
+      return VA_FOURCC_BGRX;
+    case gfx::BufferFormat::UYVY_422:
+      return VA_FOURCC_UYVY;
+    default:
+      NOTREACHED();
+      return 0;
+  }
+}
+
+uint32_t VAFourCCToVARTFormat(uint32_t fourcc) {
+  switch (fourcc) {
+    case VA_FOURCC_UYVY:
+      return VA_RT_FORMAT_YUV422;
+    case VA_FOURCC_BGRX:
+      return VA_RT_FORMAT_RGB32;
+    default:
+      NOTREACHED();
+      return 0;
+  }
+}
+
 VaapiDrmPicture::VaapiDrmPicture(
     VaapiWrapper* vaapi_wrapper,
     const base::Callback<bool(void)>& make_context_current,
     int32 picture_buffer_id,
     uint32 texture_id,
     const gfx::Size& size)
     : VaapiPicture(picture_buffer_id, texture_id, size),
       vaapi_wrapper_(vaapi_wrapper),
       make_context_current_(make_context_current),
       weak_this_factory_(this) {
@@ skipping 15 matching lines @@
   int dmabuf_fd = pixmap->GetDmaBufFd();
   if (dmabuf_fd < 0) {
     LOG(ERROR) << "Failed to get dmabuf from an Ozone NativePixmap";
     return nullptr;
   }
   int dmabuf_pitch = pixmap->GetDmaBufPitch();
 
   // Create a VASurface out of the created buffer using the dmabuf.
   VASurfaceAttribExternalBuffers va_attrib_extbuf;
   memset(&va_attrib_extbuf, 0, sizeof(va_attrib_extbuf));
-  va_attrib_extbuf.pixel_format = VA_FOURCC_BGRX;
+  va_attrib_extbuf.pixel_format =
+      BufferFormatToVAFourCC(pixmap->GetBufferFormat());
   va_attrib_extbuf.width = pixmap_size.width();
   va_attrib_extbuf.height = pixmap_size.height();
   va_attrib_extbuf.data_size = pixmap_size.height() * dmabuf_pitch;
   va_attrib_extbuf.num_planes = 1;
   va_attrib_extbuf.pitches[0] = dmabuf_pitch;
   va_attrib_extbuf.offsets[0] = 0;
   va_attrib_extbuf.buffers = reinterpret_cast<unsigned long*>(&dmabuf_fd);
   va_attrib_extbuf.num_buffers = 1;
   va_attrib_extbuf.flags = 0;
   va_attrib_extbuf.private_data = NULL;
 
   std::vector<VASurfaceAttrib> va_attribs;
   va_attribs.resize(2);
 
   va_attribs[0].type = VASurfaceAttribMemoryType;
   va_attribs[0].flags = VA_SURFACE_ATTRIB_SETTABLE;
   va_attribs[0].value.type = VAGenericValueTypeInteger;
   va_attribs[0].value.value.i = VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME;
 
   va_attribs[1].type = VASurfaceAttribExternalBufferDescriptor;
   va_attribs[1].flags = VA_SURFACE_ATTRIB_SETTABLE;
   va_attribs[1].value.type = VAGenericValueTypePointer;
   va_attribs[1].value.value.p = &va_attrib_extbuf;
 
   scoped_refptr<VASurface> va_surface = vaapi_wrapper_->CreateUnownedSurface(
-      VA_RT_FORMAT_RGB32, pixmap_size, va_attribs);
+      VAFourCCToVARTFormat(va_attrib_extbuf.pixel_format), pixmap_size,
+      va_attribs);
   if (!va_surface) {
     LOG(ERROR) << "Failed to create VASurface for an Ozone NativePixmap";
     return nullptr;
   }
 
   return va_surface;
 }
 
 scoped_refptr<ui::NativePixmap> VaapiDrmPicture::CreateNativePixmap(
-    gfx::Size size) {
+    gfx::Size size,
+    gfx::BufferFormat format) {
   ui::OzonePlatform* platform = ui::OzonePlatform::GetInstance();
   ui::SurfaceFactoryOzone* factory = platform->GetSurfaceFactoryOzone();
 
   // Create a buffer from Ozone.
-  return factory->CreateNativePixmap(gfx::kNullAcceleratedWidget, size,
-                                     gfx::BufferFormat::BGRX_8888,
+  return factory->CreateNativePixmap(gfx::kNullAcceleratedWidget, size, format,
                                      gfx::BufferUsage::GPU_READ_WRITE);
 }
 
 bool VaapiDrmPicture::Initialize() {
   // We want to create a VASurface and an EGLImage out of the same
   // memory buffer, so we can output decoded pictures to it using
   // VAAPI and also use it to paint with GL.
-  pixmap_ = CreateNativePixmap(size());
+  pixmap_ = CreateNativePixmap(size(), kPictureForGLImageFormat);
   if (!pixmap_) {
     LOG(ERROR) << "Failed creating an Ozone NativePixmap";
     return false;
   }
 
   va_surface_ = CreateVASurfaceForPixmap(pixmap_, size());
   if (!va_surface_) {
     LOG(ERROR) << "Failed creating VASurface for NativePixmap";
     return false;
   }
 
   // Weak pointers can only bind to methods without return values,
-  // hence we cannot bind ScalePixmap here. Instead we use a
+  // hence we cannot bind ProcessPixmap here. Instead we use a
   // static function to solve this problem.
-  pixmap_->SetScalingCallback(base::Bind(&VaapiDrmPicture::CallScalePixmap,
-                                         weak_this_factory_.GetWeakPtr()));
+  pixmap_->SetProcessingCallback(base::Bind(&VaapiDrmPicture::CallProcessPixmap,
+                                            weak_this_factory_.GetWeakPtr()));
 
   if (!make_context_current_.Run())
     return false;
 
   gfx::ScopedTextureBinder texture_binder(GL_TEXTURE_EXTERNAL_OES,
                                           texture_id());
   scoped_refptr<gfx::GLImageOzoneNativePixmap> image(
       new gfx::GLImageOzoneNativePixmap(size(), GL_BGRA_EXT));
-  if (!image->Initialize(pixmap_.get(), gfx::BufferFormat::BGRX_8888)) {
+  if (!image->Initialize(pixmap_.get(), kPictureForGLImageFormat)) {

[Pawel Osciak, 2015/11/05 10:23:51]

We should perhaps allow querying format from pixmap_ instead?

[william.xie1, 2015/11/06 06:56:14]

Done.

     LOG(ERROR) << "Failed to create GLImage";
     return false;
   }
   gl_image_ = image;
   if (!gl_image_->BindTexImage(GL_TEXTURE_EXTERNAL_OES)) {
     LOG(ERROR) << "Failed to bind texture to GLImage";
     return false;
   }
 
   return true;
 }
 
 bool VaapiDrmPicture::DownloadFromSurface(
     const scoped_refptr<VASurface>& va_surface) {
   return vaapi_wrapper_->BlitSurface(va_surface, va_surface_);
 }
 
 // static
-scoped_refptr<ui::NativePixmap> VaapiDrmPicture::CallScalePixmap(
+scoped_refptr<ui::NativePixmap> VaapiDrmPicture::CallProcessPixmap(
     base::WeakPtr<VaapiDrmPicture> weak_ptr,
-    gfx::Size new_size) {
+    gfx::Size target_size,
+    gfx::BufferFormat target_format) {
   if (!weak_ptr.get()) {
-    LOG(ERROR) << "Failed scaling NativePixmap as scaling "
+    LOG(ERROR) << "Failed processing NativePixmap as processing "
                   "unit(VaapiDrmPicture) is deleted";
     return nullptr;
   }
-  return weak_ptr->ScalePixmap(new_size);
+  return weak_ptr->ProcessPixmap(target_size, target_format);
 }
 
-scoped_refptr<ui::NativePixmap> VaapiDrmPicture::ScalePixmap(
-    gfx::Size new_size) {
-  if (!scaled_va_surface_.get() || scaled_va_surface_->size() != new_size) {
-    scaled_pixmap_ = CreateNativePixmap(new_size);
-    if (!scaled_pixmap_) {
-      LOG(ERROR) << "Failed creating an Ozone NativePixmap for scaling";
-      scaled_va_surface_ = nullptr;
+scoped_refptr<ui::NativePixmap> VaapiDrmPicture::ProcessPixmap(
+    gfx::Size target_size,
+    gfx::BufferFormat target_format) {
+  if (!processed_va_surface_.get() ||
+      processed_va_surface_->size() != target_size ||
+      processed_va_surface_->GetVAFormat() !=
+          VAFourCCToVARTFormat(BufferFormatToVAFourCC(target_format))) {

[Pawel Osciak, 2015/11/05 10:23:51]

We seem to always need BufferFormat->VAFourCC conversion (unless I'm missing
something), so perhaps we should have BufferFormatToVARTFormat instead of
BufferFormatToVAFourCC()?

[william.xie1, 2015/11/06 06:56:14]

Done.

+    processed_pixmap_ = CreateNativePixmap(target_size, target_format);
+    if (!processed_pixmap_) {
+      LOG(ERROR) << "Failed creating an Ozone NativePixmap for processing";
+      processed_va_surface_ = nullptr;
       return nullptr;
     }
-    scaled_va_surface_ = CreateVASurfaceForPixmap(scaled_pixmap_, new_size);
-    if (!scaled_va_surface_) {
+    processed_va_surface_ =
+        CreateVASurfaceForPixmap(processed_pixmap_, target_size);
+    if (!processed_va_surface_) {
       LOG(ERROR) << "Failed creating VA Surface for pixmap";
-      scaled_pixmap_ = nullptr;
+      processed_pixmap_ = nullptr;
       return nullptr;
     }
   }
 
-  DCHECK(scaled_pixmap_);
+  DCHECK(processed_pixmap_);
   bool vpp_result =
-      vaapi_wrapper_->BlitSurface(va_surface_, scaled_va_surface_);
+      vaapi_wrapper_->BlitSurface(va_surface_, processed_va_surface_);
   if (!vpp_result) {
     LOG(ERROR) << "Failed scaling NativePixmap";
-    scaled_pixmap_ = nullptr;
-    scaled_va_surface_ = nullptr;
+    processed_pixmap_ = nullptr;
+    processed_va_surface_ = nullptr;
     return nullptr;
   }
 
-  return scaled_pixmap_;
+  return processed_pixmap_;
 }
 
 scoped_refptr<gl::GLImage> VaapiDrmPicture::GetImageToBind() {
   return gl_image_;
 }
 
 bool VaapiDrmPicture::AllowOverlay() const {
   return true;
 }
 
 }  // namespace