Issue 14225010: Sets request_focus_on_press to false for message_center_buttons.

Issue 14225010: Sets request_focus_on_press to false for message_center_buttons. (Closed)

Created:
7 years, 8 months ago by Jun Mukai

Modified:
7 years, 8 months ago

Reviewers:
dharcourt

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sets request_focus_on_press to false for message_center_buttons. BUG=232282 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195088

Patch Set 2 : fix #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	ui/message_center/views/message_center_view.cc	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	ui/message_center/views/message_view.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/views/notification_view.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dharcourt

https://codereview.chromium.org/14225010/diff/1/ui/message_center/views/message_center_view.cc File ui/message_center/views/message_center_view.cc (left): https://codereview.chromium.org/14225010/diff/1/ui/message_center/views/message_center_view.cc#oldcode116 ui/message_center/views/message_center_view.cc:116: protected: "protected:" should be moved down two lines instead ...

7 years, 8 months ago (2013-04-17 21:58:56 UTC) #2

Jun Mukai

https://codereview.chromium.org/14225010/diff/1/ui/message_center/views/message_center_view.cc File ui/message_center/views/message_center_view.cc (left): https://codereview.chromium.org/14225010/diff/1/ui/message_center/views/message_center_view.cc#oldcode116 ui/message_center/views/message_center_view.cc:116: protected: On 2013/04/17 21:58:56, dharcourt wrote: > "protected:" should ...

7 years, 8 months ago (2013-04-18 18:16:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14225010/4001

7 years, 8 months ago (2013-04-18 20:22:39 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30389

7 years, 8 months ago (2013-04-19 00:18:42 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14225010/4001

7 years, 8 months ago (2013-04-19 00:25:26 UTC) #7

Message was sent while issue was closed.

Change committed as 195088

Expand Messages | Collapse Messages