Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: ui/views/corewm/focus_controller.h

Issue 14222019: Trying to activate a window in a workspace other than the current is ignored while a system modal d… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: nits Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/client/activation_change_observer.h ('k') | ui/views/corewm/focus_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/corewm/focus_controller.h
diff --git a/ui/views/corewm/focus_controller.h b/ui/views/corewm/focus_controller.h
index 4912a64cb506aba528e84f3ba376791df364f65e..0026436e377cc70a97aa7423ee39badd74d37bd3 100644
--- a/ui/views/corewm/focus_controller.h
+++ b/ui/views/corewm/focus_controller.h
@@ -84,11 +84,18 @@ class VIEWS_EXPORT FocusController : public aura::client::ActivationClient,
virtual void OnWindowHierarchyChanged(
const HierarchyChangeParams& params) OVERRIDE;
- // Internal implementations that set the focused/active windows, fire events
- // etc. These functions must be called with valid focusable/activatable
- // windows.
+ // Internal implementation that sets the focused window, fires events etc.
+ // This function must be called with a valid focusable window.
void SetFocusedWindow(aura::Window* window);
- void SetActiveWindow(aura::Window* window);
+
+ // Internal implementation that sets the active window, fires events etc.
+ // This function must be called with a valid |activatable_window|.
+ // |requested window| refers to the window that was passed in to an external
+ // request (e.g. FocusWindow or ActivateWindow). It may be NULL, e.g. if
+ // SetActiveWindow was not called by an external request. |activatable_window|
+ // refers to the actual window to be activated, which may be different.
+ void SetActiveWindow(aura::Window* requested_window,
+ aura::Window* activatable_window);
// Called when a window's disposition changed such that it and its hierarchy
// are no longer focusable/activatable. |next| is a valid window that is used
« no previous file with comments | « ui/aura/client/activation_change_observer.h ('k') | ui/views/corewm/focus_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698