Add a maximizing logic flag

Add a maximizing logic flag

BUG=230866
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195086

[Mr4D (OOO till 08-26), 2013-04-13 00:04:06]

Please have a look!

[James Cook, 2013-04-13 00:15:03]

https://codereview.chromium.org/14222010/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/14222010/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6714: +        Automatic window maximization.
This should have the word "Disable" and no . at the end

https://codereview.chromium.org/14222010/diff/1/chrome/browser/ui/window_size...
File chrome/browser/ui/window_sizer/window_sizer_ash.cc (right):

https://codereview.chromium.org/14222010/diff/1/chrome/browser/ui/window_size...
chrome/browser/ui/window_sizer/window_sizer_ash.cc:146:
kForceMaximizeWidthLimitDisabled : kForceMaximizeWidthLimit;
Is there a way to actually disable the code that enforces the threshold, rather
than changing the threshold to an artificially low value?

(Also, I only see the function called in a unit test on cs.chromium.org - does
changing this function actually disable the behavior?)

[skuhne, 2013-04-13 00:21:28]

Addressed - please have another look!

https://codereview.chromium.org/14222010/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/14222010/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6714: +        Automatic window maximization.
Done.

https://codereview.chromium.org/14222010/diff/1/chrome/browser/ui/window_size...
File chrome/browser/ui/window_sizer/window_sizer_ash.cc (right):

https://codereview.chromium.org/14222010/diff/1/chrome/browser/ui/window_size...
chrome/browser/ui/window_sizer/window_sizer_ash.cc:146:
kForceMaximizeWidthLimitDisabled : kForceMaximizeWidthLimit;
1) LOL - yeah right. I have thought about doing it and somehow either forgot or
reverted the change where I read the value.
2) There is logic to it - if you run on such a low resolution you really really
really want to run maximized.
If you do not agree in 2.) I will deactivate it for good.

[James Cook, 2013-04-15 15:15:16]

lgtm

[commit-bot: I haz the power, 2013-04-17 23:26:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/14222010/10002

[commit-bot: I haz the power, 2013-04-17 23:26:05]

Presubmit check for 14222010-10002 failed and returned exit status 1.

INFO:root:Found 5 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ui/window_sizer/window_sizer_ash.cc

Presubmit checks took 1.2s to calculate.

[Mr4D (OOO till 08-26), 2013-04-18 00:19:32]

Sky, could you please do an owners review? Thanks!

[Mr4D (OOO till 08-26), 2013-04-18 14:31:55]

Hello Ben! Can you do a quick owners review?

[Ben Goodger (Google), 2013-04-18 16:15:22]

lgtm

[commit-bot: I haz the power, 2013-04-18 16:16:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/14222010/10002

[commit-bot: I haz the power, 2013-04-18 18:36:49]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-18 18:38:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/14222010/10002

[commit-bot: I haz the power, 2013-04-18 23:38:55]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-19 00:00:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/14222010/10002

[commit-bot: I haz the power, 2013-04-19 04:00:23]

Change committed as 195086