Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: media/filters/decrypting_demuxer_stream.h

Issue 14217008: Remove reference counting from media::DemuxerStream and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/decrypting_audio_decoder_unittest.cc ('k') | media/filters/decrypting_demuxer_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decrypting_demuxer_stream.h
diff --git a/media/filters/decrypting_demuxer_stream.h b/media/filters/decrypting_demuxer_stream.h
index 0da4368b5194170a0db8153b8711a0039cf5cac3..1b4de64d604e9e81357d936ae03a3bada5664931 100644
--- a/media/filters/decrypting_demuxer_stream.h
+++ b/media/filters/decrypting_demuxer_stream.h
@@ -7,6 +7,7 @@
#include "base/callback.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "media/base/decryptor.h"
#include "media/base/demuxer_stream.h"
@@ -27,8 +28,9 @@ class MEDIA_EXPORT DecryptingDemuxerStream : public DemuxerStream {
DecryptingDemuxerStream(
const scoped_refptr<base::MessageLoopProxy>& message_loop,
const SetDecryptorReadyCB& set_decryptor_ready_cb);
+ virtual ~DecryptingDemuxerStream();
- void Initialize(const scoped_refptr<DemuxerStream>& stream,
+ void Initialize(DemuxerStream* stream,
const PipelineStatusCB& status_cb);
void Reset(const base::Closure& closure);
@@ -39,9 +41,6 @@ class MEDIA_EXPORT DecryptingDemuxerStream : public DemuxerStream {
virtual Type type() OVERRIDE;
virtual void EnableBitstreamConverter() OVERRIDE;
- protected:
- virtual ~DecryptingDemuxerStream();
-
private:
// For a detailed state diagram please see this link: http://goo.gl/8jAok
// TODO(xhwang): Add a ASCII state diagram in this file after this class
@@ -84,6 +83,8 @@ class MEDIA_EXPORT DecryptingDemuxerStream : public DemuxerStream {
void InitializeDecoderConfig();
scoped_refptr<base::MessageLoopProxy> message_loop_;
+ base::WeakPtrFactory<DecryptingDemuxerStream> weak_factory_;
+ base::WeakPtr<DecryptingDemuxerStream> weak_this_;
State state_;
@@ -92,7 +93,7 @@ class MEDIA_EXPORT DecryptingDemuxerStream : public DemuxerStream {
base::Closure reset_cb_;
// Pointer to the input demuxer stream that will feed us encrypted buffers.
- scoped_refptr<DemuxerStream> demuxer_stream_;
+ DemuxerStream* demuxer_stream_;
scoped_ptr<AudioDecoderConfig> audio_config_;
scoped_ptr<VideoDecoderConfig> video_config_;
« no previous file with comments | « media/filters/decrypting_audio_decoder_unittest.cc ('k') | media/filters/decrypting_demuxer_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698