Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: media/filters/chunk_demuxer.h

Issue 14217008: Remove reference counting from media::DemuxerStream and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_impl_unittest.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index a5cfc316306d6f0d94a2ff17ffaef3c2923b695c..a5fd6f0abcde8d78d54994a7d87279c62356d90d 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -53,8 +53,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
virtual void Stop(const base::Closure& callback) OVERRIDE;
virtual void Seek(base::TimeDelta time, const PipelineStatusCB& cb) OVERRIDE;
virtual void OnAudioRendererDisabled() OVERRIDE;
- virtual scoped_refptr<DemuxerStream> GetStream(
- DemuxerStream::Type type) OVERRIDE;
+ virtual DemuxerStream* GetStream(DemuxerStream::Type type) OVERRIDE;
virtual base::TimeDelta GetStartTime() const OVERRIDE;
// Methods used by an external object to control this demuxer.
@@ -157,7 +156,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
// |stream|.
void IncreaseDurationIfNecessary(
const StreamParser::BufferQueue& buffers,
- const scoped_refptr<ChunkDemuxerStream>& stream);
+ ChunkDemuxerStream* stream);
// Decreases |duration_| if the buffered region is less than |duration_| when
// EndOfStream() is called.
@@ -183,8 +182,11 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
PipelineStatusCB init_cb_;
PipelineStatusCB seek_cb_;
- scoped_refptr<ChunkDemuxerStream> audio_;
- scoped_refptr<ChunkDemuxerStream> video_;
+ scoped_ptr<ChunkDemuxerStream> audio_;
+ scoped_ptr<ChunkDemuxerStream> video_;
+
+ // Keeps |audio_| alive when audio has been disabled.
+ scoped_ptr<ChunkDemuxerStream> disabled_audio_;
base::TimeDelta duration_;
« no previous file with comments | « media/filters/audio_renderer_impl_unittest.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698