Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: media/base/mock_filters.h

Issue 14217008: Remove reference counting from media::DemuxerStream and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/demuxer_stream.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mock_filters.h
diff --git a/media/base/mock_filters.h b/media/base/mock_filters.h
index a007fa5ca48762ce730481a2f95292b34b3419a9..5bc907171f5020aa6b0c16975134a53ee926bc5b 100644
--- a/media/base/mock_filters.h
+++ b/media/base/mock_filters.h
@@ -35,7 +35,7 @@ class MockDemuxer : public Demuxer {
MOCK_METHOD2(Seek, void(base::TimeDelta time, const PipelineStatusCB& cb));
MOCK_METHOD1(Stop, void(const base::Closure& callback));
MOCK_METHOD0(OnAudioRendererDisabled, void());
- MOCK_METHOD1(GetStream, scoped_refptr<DemuxerStream>(DemuxerStream::Type));
+ MOCK_METHOD1(GetStream, DemuxerStream*(DemuxerStream::Type));
MOCK_CONST_METHOD0(GetStartTime, base::TimeDelta());
private:
@@ -45,6 +45,7 @@ class MockDemuxer : public Demuxer {
class MockDemuxerStream : public DemuxerStream {
public:
MockDemuxerStream(DemuxerStream::Type type);
+ virtual ~MockDemuxerStream();
// DemuxerStream implementation.
virtual Type type() OVERRIDE;
@@ -56,9 +57,6 @@ class MockDemuxerStream : public DemuxerStream {
void set_audio_decoder_config(const AudioDecoderConfig& config);
void set_video_decoder_config(const VideoDecoderConfig& config);
- protected:
- virtual ~MockDemuxerStream();
-
private:
DemuxerStream::Type type_;
AudioDecoderConfig audio_decoder_config_;
@@ -70,9 +68,10 @@ class MockDemuxerStream : public DemuxerStream {
class MockVideoDecoder : public VideoDecoder {
public:
MockVideoDecoder();
+ virtual ~MockVideoDecoder();
// VideoDecoder implementation.
- MOCK_METHOD3(Initialize, void(const scoped_refptr<DemuxerStream>&,
+ MOCK_METHOD3(Initialize, void(DemuxerStream*,
const PipelineStatusCB&,
const StatisticsCB&));
MOCK_METHOD1(Read, void(const ReadCB&));
@@ -80,9 +79,6 @@ class MockVideoDecoder : public VideoDecoder {
MOCK_METHOD1(Stop, void(const base::Closure&));
MOCK_CONST_METHOD0(HasAlpha, bool());
- protected:
- virtual ~MockVideoDecoder();
-
private:
DISALLOW_COPY_AND_ASSIGN(MockVideoDecoder);
};
@@ -90,9 +86,10 @@ class MockVideoDecoder : public VideoDecoder {
class MockAudioDecoder : public AudioDecoder {
public:
MockAudioDecoder();
+ virtual ~MockAudioDecoder();
// AudioDecoder implementation.
- MOCK_METHOD3(Initialize, void(const scoped_refptr<DemuxerStream>&,
+ MOCK_METHOD3(Initialize, void(DemuxerStream*,
const PipelineStatusCB&,
const StatisticsCB&));
MOCK_METHOD1(Read, void(const ReadCB&));
@@ -101,9 +98,6 @@ class MockAudioDecoder : public AudioDecoder {
MOCK_METHOD0(samples_per_second, int(void));
MOCK_METHOD1(Reset, void(const base::Closure&));
- protected:
- virtual ~MockAudioDecoder();
-
private:
DISALLOW_COPY_AND_ASSIGN(MockAudioDecoder);
};
@@ -114,7 +108,7 @@ class MockVideoRenderer : public VideoRenderer {
virtual ~MockVideoRenderer();
// VideoRenderer implementation.
- MOCK_METHOD9(Initialize, void(const scoped_refptr<DemuxerStream>& stream,
+ MOCK_METHOD9(Initialize, void(DemuxerStream* stream,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const TimeCB& time_cb,
@@ -140,7 +134,7 @@ class MockAudioRenderer : public AudioRenderer {
virtual ~MockAudioRenderer();
// AudioRenderer implementation.
- MOCK_METHOD8(Initialize, void(const scoped_refptr<DemuxerStream>& stream,
+ MOCK_METHOD8(Initialize, void(DemuxerStream* stream,
const PipelineStatusCB& init_cb,
const StatisticsCB& statistics_cb,
const base::Closure& underflow_cb,
« no previous file with comments | « media/base/demuxer_stream.h ('k') | media/base/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698