Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: media/base/pipeline_unittest.cc

Issue 14217008: Remove reference counting from media::DemuxerStream and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/video_decoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/test/simple_test_clock.h" 10 #include "base/test/simple_test_clock.h"
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 typedef std::vector<MockDemuxerStream*> MockDemuxerStreamVector; 134 typedef std::vector<MockDemuxerStream*> MockDemuxerStreamVector;
135 void InitializeDemuxer(MockDemuxerStreamVector* streams, 135 void InitializeDemuxer(MockDemuxerStreamVector* streams,
136 const base::TimeDelta& duration) { 136 const base::TimeDelta& duration) {
137 EXPECT_CALL(callbacks_, OnDurationChange()); 137 EXPECT_CALL(callbacks_, OnDurationChange());
138 EXPECT_CALL(*demuxer_, Initialize(_, _)) 138 EXPECT_CALL(*demuxer_, Initialize(_, _))
139 .WillOnce(DoAll(SetDemuxerProperties(duration), 139 .WillOnce(DoAll(SetDemuxerProperties(duration),
140 RunCallback<1>(PIPELINE_OK))); 140 RunCallback<1>(PIPELINE_OK)));
141 141
142 // Configure the demuxer to return the streams. 142 // Configure the demuxer to return the streams.
143 for (size_t i = 0; i < streams->size(); ++i) { 143 for (size_t i = 0; i < streams->size(); ++i) {
144 scoped_refptr<DemuxerStream> stream((*streams)[i]); 144 DemuxerStream* stream = (*streams)[i];
145 EXPECT_CALL(*demuxer_, GetStream(stream->type())) 145 EXPECT_CALL(*demuxer_, GetStream(stream->type()))
146 .WillRepeatedly(Return(stream)); 146 .WillRepeatedly(Return(stream));
147 } 147 }
148 } 148 }
149 149
150 void InitializeDemuxer(MockDemuxerStreamVector* streams) { 150 void InitializeDemuxer(MockDemuxerStreamVector* streams) {
151 // Initialize with a default non-zero duration. 151 // Initialize with a default non-zero duration.
152 InitializeDemuxer(streams, base::TimeDelta::FromSeconds(10)); 152 InitializeDemuxer(streams, base::TimeDelta::FromSeconds(10));
153 } 153 }
154 154
155 StrictMock<MockDemuxerStream>* CreateStream(DemuxerStream::Type type) { 155 scoped_ptr<StrictMock<MockDemuxerStream> > CreateStream(
156 StrictMock<MockDemuxerStream>* stream = 156 DemuxerStream::Type type) {
157 new StrictMock<MockDemuxerStream>(type); 157 scoped_ptr<StrictMock<MockDemuxerStream> > stream(
158 return stream; 158 new StrictMock<MockDemuxerStream>(type));
159 return stream.Pass();
159 } 160 }
160 161
161 // Sets up expectations to allow the video renderer to initialize. 162 // Sets up expectations to allow the video renderer to initialize.
162 void InitializeVideoRenderer(const scoped_refptr<DemuxerStream>& stream) { 163 void InitializeVideoRenderer(DemuxerStream* stream) {
163 EXPECT_CALL(*video_renderer_, Initialize(stream, _, _, _, _, _, _, _, _)) 164 EXPECT_CALL(*video_renderer_, Initialize(stream, _, _, _, _, _, _, _, _))
164 .WillOnce(RunCallback<1>(PIPELINE_OK)); 165 .WillOnce(RunCallback<1>(PIPELINE_OK));
165 EXPECT_CALL(*video_renderer_, SetPlaybackRate(0.0f)); 166 EXPECT_CALL(*video_renderer_, SetPlaybackRate(0.0f));
166 167
167 // Startup sequence. 168 // Startup sequence.
168 EXPECT_CALL(*video_renderer_, Preroll(demuxer_->GetStartTime(), _)) 169 EXPECT_CALL(*video_renderer_, Preroll(demuxer_->GetStartTime(), _))
169 .WillOnce(RunCallback<1>(PIPELINE_OK)); 170 .WillOnce(RunCallback<1>(PIPELINE_OK));
170 EXPECT_CALL(*video_renderer_, Play(_)) 171 EXPECT_CALL(*video_renderer_, Play(_))
171 .WillOnce(RunClosure<0>()); 172 .WillOnce(RunClosure<0>());
172 } 173 }
173 174
174 // Sets up expectations to allow the audio renderer to initialize. 175 // Sets up expectations to allow the audio renderer to initialize.
175 void InitializeAudioRenderer(const scoped_refptr<DemuxerStream>& stream, 176 void InitializeAudioRenderer(DemuxerStream* stream,
176 bool disable_after_init_cb) { 177 bool disable_after_init_cb) {
177 if (disable_after_init_cb) { 178 if (disable_after_init_cb) {
178 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _, _)) 179 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _, _))
179 .WillOnce(DoAll(RunCallback<1>(PIPELINE_OK), 180 .WillOnce(DoAll(RunCallback<1>(PIPELINE_OK),
180 WithArg<6>(RunClosure<0>()))); // |disabled_cb|. 181 WithArg<6>(RunClosure<0>()))); // |disabled_cb|.
181 } else { 182 } else {
182 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _, _)) 183 EXPECT_CALL(*audio_renderer_, Initialize(stream, _, _, _, _, _, _, _))
183 .WillOnce(DoAll(SaveArg<4>(&audio_time_cb_), 184 .WillOnce(DoAll(SaveArg<4>(&audio_time_cb_),
184 RunCallback<1>(PIPELINE_OK))); 185 RunCallback<1>(PIPELINE_OK)));
185 } 186 }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 void CreateAudioStream() { 223 void CreateAudioStream() {
223 audio_stream_ = CreateStream(DemuxerStream::AUDIO); 224 audio_stream_ = CreateStream(DemuxerStream::AUDIO);
224 } 225 }
225 226
226 void CreateVideoStream() { 227 void CreateVideoStream() {
227 video_stream_ = CreateStream(DemuxerStream::VIDEO); 228 video_stream_ = CreateStream(DemuxerStream::VIDEO);
228 video_stream_->set_video_decoder_config(video_decoder_config_); 229 video_stream_->set_video_decoder_config(video_decoder_config_);
229 } 230 }
230 231
231 MockDemuxerStream* audio_stream() { 232 MockDemuxerStream* audio_stream() {
232 return audio_stream_; 233 return audio_stream_.get();
233 } 234 }
234 235
235 MockDemuxerStream* video_stream() { 236 MockDemuxerStream* video_stream() {
236 return video_stream_; 237 return video_stream_.get();
237 } 238 }
238 239
239 void ExpectSeek(const base::TimeDelta& seek_time) { 240 void ExpectSeek(const base::TimeDelta& seek_time) {
240 // Every filter should receive a call to Seek(). 241 // Every filter should receive a call to Seek().
241 EXPECT_CALL(*demuxer_, Seek(seek_time, _)) 242 EXPECT_CALL(*demuxer_, Seek(seek_time, _))
242 .WillOnce(RunCallback<1>(PIPELINE_OK)); 243 .WillOnce(RunCallback<1>(PIPELINE_OK));
243 EXPECT_CALL(*demuxer_, SetPlaybackRate(_)); 244 EXPECT_CALL(*demuxer_, SetPlaybackRate(_));
244 245
245 if (audio_stream_) { 246 if (audio_stream_) {
246 EXPECT_CALL(*audio_renderer_, Pause(_)) 247 EXPECT_CALL(*audio_renderer_, Pause(_))
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 // Fixture members. 288 // Fixture members.
288 StrictMock<CallbackHelper> callbacks_; 289 StrictMock<CallbackHelper> callbacks_;
289 base::SimpleTestClock test_clock_; 290 base::SimpleTestClock test_clock_;
290 base::MessageLoop message_loop_; 291 base::MessageLoop message_loop_;
291 scoped_refptr<Pipeline> pipeline_; 292 scoped_refptr<Pipeline> pipeline_;
292 293
293 scoped_ptr<FilterCollection> filter_collection_; 294 scoped_ptr<FilterCollection> filter_collection_;
294 scoped_ptr<MockDemuxer> demuxer_; 295 scoped_ptr<MockDemuxer> demuxer_;
295 MockVideoRenderer* video_renderer_; 296 MockVideoRenderer* video_renderer_;
296 MockAudioRenderer* audio_renderer_; 297 MockAudioRenderer* audio_renderer_;
297 scoped_refptr<StrictMock<MockDemuxerStream> > audio_stream_; 298 scoped_ptr<StrictMock<MockDemuxerStream> > audio_stream_;
298 scoped_refptr<StrictMock<MockDemuxerStream> > video_stream_; 299 scoped_ptr<StrictMock<MockDemuxerStream> > video_stream_;
299 AudioRenderer::TimeCB audio_time_cb_; 300 AudioRenderer::TimeCB audio_time_cb_;
300 VideoDecoderConfig video_decoder_config_; 301 VideoDecoderConfig video_decoder_config_;
301 302
302 private: 303 private:
303 DISALLOW_COPY_AND_ASSIGN(PipelineTest); 304 DISALLOW_COPY_AND_ASSIGN(PipelineTest);
304 }; 305 };
305 306
306 // Test that playback controls methods no-op when the pipeline hasn't been 307 // Test that playback controls methods no-op when the pipeline hasn't been
307 // started. 308 // started.
308 TEST_F(PipelineTest, NotStarted) { 309 TEST_F(PipelineTest, NotStarted) {
(...skipping 895 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 INSTANTIATE_TEARDOWN_TEST(Error, InitAudioRenderer); 1205 INSTANTIATE_TEARDOWN_TEST(Error, InitAudioRenderer);
1205 INSTANTIATE_TEARDOWN_TEST(Error, InitVideoRenderer); 1206 INSTANTIATE_TEARDOWN_TEST(Error, InitVideoRenderer);
1206 INSTANTIATE_TEARDOWN_TEST(Error, Pausing); 1207 INSTANTIATE_TEARDOWN_TEST(Error, Pausing);
1207 INSTANTIATE_TEARDOWN_TEST(Error, Flushing); 1208 INSTANTIATE_TEARDOWN_TEST(Error, Flushing);
1208 INSTANTIATE_TEARDOWN_TEST(Error, Seeking); 1209 INSTANTIATE_TEARDOWN_TEST(Error, Seeking);
1209 INSTANTIATE_TEARDOWN_TEST(Error, Prerolling); 1210 INSTANTIATE_TEARDOWN_TEST(Error, Prerolling);
1210 INSTANTIATE_TEARDOWN_TEST(Error, Starting); 1211 INSTANTIATE_TEARDOWN_TEST(Error, Starting);
1211 INSTANTIATE_TEARDOWN_TEST(Error, Playing); 1212 INSTANTIATE_TEARDOWN_TEST(Error, Playing);
1212 1213
1213 } // namespace media 1214 } // namespace media
OLDNEW
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/video_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698