Add an Android Component builder and tester to the FYI waterfall.

Add an Android Component builder and tester to the FYI waterfall.

BUG=178878
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=197136

[Siva Chandra, 2013-04-18 20:26:34]

I tried to use 'shared' wherever possible in the names.

[Siva Chandra, 2013-04-18 20:28:49]

On 2013/04/18 20:26:34, Siva Chandra wrote:
> I tried to use 'shared' wherever possible in the names.

Another open question is, should we use Galaxy Nexus or something else? Though I
have put Galaxy Nexus in the CL, I would prefer Nakasi as they seem to be more
stable.

[Yaron, 2013-04-18 20:49:10]

I'm indifferent. Nakasi is fine. I don't see a tryserver mentioned.. is that
implicit?

[Isaac (away), 2013-04-18 20:51:14]

Thanks for CL -- I have some comments for you to get started.  I also suggest
running 'git cl presubmit' (which runs the commit presubmits) before uploading. 
It's a lot faster now and should catch common issues like syntax errors.

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
File masters/master.chromium.fyi/master.cfg (left):

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:335: chromium_android_fyi_dbg_archive =
master_config.GetGSUtilUrl(
You'll need to add an archive here.  I think it's time to make this a dict.

chromium_android_archives = {}
chromium_android_archives['fyi_dbg'] = ...
etc

Then replace calls below with a dict lookup.

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
File masters/master.chromium.fyi/master.cfg (right):

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:256: s_chromium_android_asan,
add scheduler here

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:1172: 'android_bot_id':
'fyi-builder-dbg',
give it unique id:

fyi-component-builder-dbg

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:1173: 'build_url':
chromium_android_fyi_dbg_archive,
needs its own bucket

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:1174: 'buildtool': 'ninja',
this value is ignored, remove it

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:1176: 'extra_gyp_defines':
'component=shared_library'
We're not putting configuration in this file; this type of config should go into
src/build/android/buildbot/bb_run_bot

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/master.cfg:1180: def
f_chromium_dbg_android_tests(bot_id_suffix):
change function to specify build, perhaps.

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
File masters/master.chromium.fyi/slaves.cfg (right):

https://chromiumcodereview.appspot.com/14208018/diff/1001/masters/master.chro...
masters/master.chromium.fyi/slaves.cfg:388: 'version': 'precise',
not sure this will work -- precise builder and lucid tester?

[Siva Chandra, 2013-04-18 20:51:33]

On 2013/04/18 20:49:10, Yaron wrote:
> I don't see a tryserver mentioned.. is that implicit?

Do you also want a tryserver? I do not think it is implicit.

[Isaac (away), 2013-04-18 20:56:34]

Let's just make this a builder/tester for now.  Just use the chromeperf81
machine instead of ferrying build zips.

[Yaron, 2013-04-18 20:59:55]

We don't need a tryserver persay, but why not add one so a dev can test their
change before commit?

[Siva Chandra, 2013-04-19 00:55:15]

This CL now depends on another CL:
https://chromiumcodereview.appspot.com/14192007/

However, you can still independently review patch set 3.

[Siva Chandra, 2013-04-26 02:05:59]

On 2013/04/19 00:55:15, Siva Chandra wrote:
> This CL now depends on another CL:
> https://chromiumcodereview.appspot.com/14192007/
> 
> However, you can still independently review patch set 3.

PING

[Yaron, 2013-04-26 02:24:33]

lgtm from me ( I assume you actually need Isaac's review )

[Isaac (away), 2013-04-29 01:54:48]

lgtm, let's just put extra_gyp_defines in here, I guess.  it's not as big a deal
to restart fyi waterfall and this gyp variable is unlikely to change.

[Isaac (away), 2013-04-29 01:59:19]

sorry, one other change:

now that it's a builder/tester, could you update the id to:

'component-fyi-builder-tests-dbg'

[Isaac (away), 2013-04-29 02:00:14]

'fyi-component-builder-tests-dbg' *

[commit-bot: I haz the power, 2013-04-29 20:59:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/14208018/17001

[commit-bot: I haz the power, 2013-04-29 20:59:52]

Change committed as 197136

[Isaac (away), 2013-05-01 00:28:51]

Hi Siva, this put the component builder at the beginning of the android column,
while it should be at the end.  Could you post a follow up CL moving it to the
end?  Thanks.