Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3803)

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc

Issue 14208014: Simplify adding callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix, sync. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
index b83dd78b23939b449069bcdf8e75153099df4039..edb0952750b7450d44fea8f78ac28eb54a0e43de 100644
--- a/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
@@ -134,18 +134,13 @@ void NetworkScreenHandler::RegisterMessages() {
// NetworkScreenHandler, private: ----------------------------------------------
-void NetworkScreenHandler::HandleOnExit(const ListValue* args) {
+void NetworkScreenHandler::HandleOnExit() {
ClearErrors();
if (screen_)
screen_->OnContinuePressed();
}
-void NetworkScreenHandler::HandleOnLanguageChanged(const ListValue* args) {
- DCHECK(args->GetSize() == 1);
- std::string locale;
- if (!args->GetString(0, &locale))
- NOTREACHED();
-
+void NetworkScreenHandler::HandleOnLanguageChanged(const std::string& locale) {
const std::string app_locale = g_browser_process->GetApplicationLocale();
if (app_locale == locale)
return;
@@ -161,11 +156,7 @@ void NetworkScreenHandler::HandleOnLanguageChanged(const ListValue* args) {
EnableContinue(is_continue_enabled_);
}
-void NetworkScreenHandler::HandleOnInputMethodChanged(const ListValue* args) {
- DCHECK(args->GetSize() == 1);
- std::string id;
- if (!args->GetString(0, &id))
- NOTREACHED();
+void NetworkScreenHandler::HandleOnInputMethodChanged(const std::string& id) {
input_method::GetInputMethodManager()->ChangeInputMethod(id);
}

Powered by Google App Engine
This is Rietveld 408576698