Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 14208013: Addding support for -webkit-background-blend-mode to blink. (Closed)

Created:
7 years, 8 months ago by Horia Olaru
Modified:
7 years, 7 months ago
CC:
blink-reviews, jamesr, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Addding support for the background-blend-mode CSS property. The patch forwards the background blend modes from WebCore to Skia, enabling background images to blend between themeselves. Added 3 pixel tests. The first two, effect-background-blend-mode and effect-background-blend-mode-stacking are just readded after being removed in CL 149989. They were removed because they failed, since background blend mode was not implemented, and TestExpectations entries were ignored. The effect-background-blend-mode-tiled test is new, and causes Image::drawPattern to be called (since the other background blending tests did not go through that function). Add logic to override the acceleratedCompositingEnabled setting on testRunner through the WebKitAcceleratedCompositingEnabled key. This was necessary because blending was rendered in software in Skia until not long ago, and there was no hardware path available. R=eric@chromium.org BUG=229166 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150710

Patch Set 1 #

Patch Set 2 : Rebasing after rename of WebCore. Remove webkit prefix from background-blend-mode property. #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Address comments #

Patch Set 5 : Remove expected pngs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, --1 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/css3/compositing/effect-background-blend-mode.html View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A + LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/css3/compositing/effect-background-blend-mode-tiled.html View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A + LayoutTests/css3/compositing/effect-background-blend-mode-tiled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/platform/graphics/skia/ImageSkia.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Horia Olaru
The changes to SkiaUtils are also a part of Issue 229111, which is part of ...
7 years, 8 months ago (2013-04-16 16:13:45 UTC) #1
eseidel
James or Stephen are much better reviewers for this than I am.
7 years, 7 months ago (2013-05-17 07:01:17 UTC) #2
Stephen Chennney
Before you commit, I suggest adding the tests to TestExpectations as there is a significant ...
7 years, 7 months ago (2013-05-17 18:54:50 UTC) #3
Peter Kasting
There are lots of reviewers listed on this CL. I don't know if Eric added ...
7 years, 7 months ago (2013-05-17 18:59:54 UTC) #4
Stephen Chennney
On 2013/05/17 18:54:50, Stephen Chenney wrote: > Before you commit, I suggest adding the tests ...
7 years, 7 months ago (2013-05-17 19:04:33 UTC) #5
Stephen White
https://codereview.chromium.org/14208013/diff/8001/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp File Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp (right): https://codereview.chromium.org/14208013/diff/8001/Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp#newcode1636 Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:1636: else if (key == "WebKitAcceleratedCompositingEnabled") I don't think there's ...
7 years, 7 months ago (2013-05-17 19:16:23 UTC) #6
Horia Olaru
I have removed the changes to TestRunner to set accelerated compositing, as well as the ...
7 years, 7 months ago (2013-05-20 13:56:02 UTC) #7
Stephen Chennney
LGTM With the png images you will not be able to use the commit queue ...
7 years, 7 months ago (2013-05-20 20:53:05 UTC) #8
Horia Olaru
On 2013/05/20 20:53:05, Stephen Chenney wrote: > LGTM > > With the png images you ...
7 years, 7 months ago (2013-05-20 21:02:34 UTC) #9
Horia Olaru
1. Done. Thing is, running the tests locally now seems to generate new pngs. Am ...
7 years, 7 months ago (2013-05-20 21:12:13 UTC) #10
Stephen Chennney
On 2013/05/20 21:12:13, Horia Olaru wrote: > 1. Done. > Thing is, running the tests ...
7 years, 7 months ago (2013-05-20 21:26:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/olaru@adobe.com/14208013/30001
7 years, 7 months ago (2013-05-20 21:27:15 UTC) #12
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 22:50:05 UTC) #13
Message was sent while issue was closed.
Change committed as 150710

Powered by Google App Engine
This is Rietveld 408576698