Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 14208006: Use updated toolchain for video quality comparison (Closed)

Created:
7 years, 8 months ago by kjellander_chromium
Modified:
7 years, 6 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Use updated toolchain for video quality comparison The barcode_decoder and frame_analyzer steps have been simplified to execute by the new compare_videos.py script in http://review.webrtc.org/1320007/ This CL removed unnecessary boilerplate code for the WebRTC Video Quality test. BUG=none TEST=chrome/test/functional/webrtc_video_quality.py (since the compare_videos.py script is present as webrtc_revision in Chrome DEPS is >4022) NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202534

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -75 lines) Patch
M chrome/test/functional/webrtc_video_quality.py View 1 3 chunks +44 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kjellander_chromium
7 years, 7 months ago (2013-04-29 17:30:25 UTC) #1
phoglund_chromium
lgtm, one nit/comment. https://codereview.chromium.org/14208006/diff/1/chrome/test/functional/webrtc_video_quality.py File chrome/test/functional/webrtc_video_quality.py (right): https://codereview.chromium.org/14208006/diff/1/chrome/test/functional/webrtc_video_quality.py#newcode286 chrome/test/functional/webrtc_video_quality.py:286: The script depends on two external ...
7 years, 7 months ago (2013-04-30 07:38:28 UTC) #2
kjellander_chromium
Updated documentation according to you comment. https://codereview.chromium.org/14208006/diff/1/chrome/test/functional/webrtc_video_quality.py File chrome/test/functional/webrtc_video_quality.py (right): https://codereview.chromium.org/14208006/diff/1/chrome/test/functional/webrtc_video_quality.py#newcode286 chrome/test/functional/webrtc_video_quality.py:286: The script depends ...
7 years, 7 months ago (2013-05-09 08:32:33 UTC) #3
phoglund_chromium
lgtm
7 years, 7 months ago (2013-05-13 07:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/14208006/5001
7 years, 6 months ago (2013-05-28 11:28:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/14208006/5001
7 years, 6 months ago (2013-05-28 11:30:16 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-28 11:30:24 UTC) #7
Message was sent while issue was closed.
Change committed as 202534

Powered by Google App Engine
This is Rietveld 408576698