Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: pkg/analyzer_experimental/test/generated/parser_test.dart

Issue 14205011: Issue 9845. Compare runtime types using ==. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_experimental/test/generated/parser_test.dart
diff --git a/pkg/analyzer_experimental/test/generated/parser_test.dart b/pkg/analyzer_experimental/test/generated/parser_test.dart
index 202e71f9e1b016f33abf043aee03e3aa1fc5a2a1..018ada0dd00ae1e06cd58d959cc0f3cfb5530a07 100644
--- a/pkg/analyzer_experimental/test/generated/parser_test.dart
+++ b/pkg/analyzer_experimental/test/generated/parser_test.dart
@@ -6198,13 +6198,13 @@ class ASTValidator extends GeneralizingASTVisitor<Object> {
* @param node the AST node being validated
*/
void validate(ASTNode node) {
- ASTNode parent21 = node.parent;
+ ASTNode parent22 = node.parent;
if (node is CompilationUnit) {
- if (parent21 != null) {
+ if (parent22 != null) {
_errors.add("Compilation units should not have a parent");
}
} else {
- if (parent21 == null) {
+ if (parent22 == null) {
_errors.add("No parent for ${node.runtimeType.toString()}");
}
}
@@ -6219,15 +6219,15 @@ class ASTValidator extends GeneralizingASTVisitor<Object> {
if (nodeStart < 0 || nodeLength < 0) {
_errors.add("No source info for ${node.runtimeType.toString()}");
}
- if (parent21 != null) {
+ if (parent22 != null) {
int nodeEnd = nodeStart + nodeLength;
- int parentStart = parent21.offset;
- int parentEnd = parentStart + parent21.length;
+ int parentStart = parent22.offset;
+ int parentEnd = parentStart + parent22.length;
if (nodeStart < parentStart) {
- _errors.add("Invalid source start (${nodeStart}) for ${node.runtimeType.toString()} inside ${parent21.runtimeType.toString()} (${parentStart})");
+ _errors.add("Invalid source start (${nodeStart}) for ${node.runtimeType.toString()} inside ${parent22.runtimeType.toString()} (${parentStart})");
}
if (nodeEnd > parentEnd) {
- _errors.add("Invalid source end (${nodeEnd}) for ${node.runtimeType.toString()} inside ${parent21.runtimeType.toString()} (${parentStart})");
+ _errors.add("Invalid source end (${nodeEnd}) for ${node.runtimeType.toString()} inside ${parent22.runtimeType.toString()} (${parentStart})");
}
}
}
@@ -7676,6 +7676,18 @@ class ErrorParserTest extends ParserTestCase {
void test_staticTopLevelDeclaration_variable() {
ParserTestCase.parse5("parseCompilationUnit", "static var x;", [ParserErrorCode.STATIC_TOP_LEVEL_DECLARATION]);
}
+ void test_switchHasCaseAfterDefaultCase() {
+ ParserTestCase.parse5("parseSwitchStatement", "switch (a) {default: return 0; case 1: return 1;}", [ParserErrorCode.SWITCH_HAS_CASE_AFTER_DEFAULT_CASE]);
+ }
+ void test_switchHasCaseAfterDefaultCase_repeated() {
+ ParserTestCase.parse5("parseSwitchStatement", "switch (a) {default: return 0; case 1: return 1; case 2: return 2;}", [ParserErrorCode.SWITCH_HAS_CASE_AFTER_DEFAULT_CASE, ParserErrorCode.SWITCH_HAS_CASE_AFTER_DEFAULT_CASE]);
+ }
+ void test_switchHasMultipleDefaultCases() {
+ ParserTestCase.parse5("parseSwitchStatement", "switch (a) {default: return 0; default: return 1;}", [ParserErrorCode.SWITCH_HAS_MULTIPLE_DEFAULT_CASES]);
+ }
+ void test_switchHasMultipleDefaultCases_repeated() {
+ ParserTestCase.parse5("parseSwitchStatement", "switch (a) {default: return 0; default: return 1; default: return 2;}", [ParserErrorCode.SWITCH_HAS_MULTIPLE_DEFAULT_CASES, ParserErrorCode.SWITCH_HAS_MULTIPLE_DEFAULT_CASES]);
+ }
void test_topLevelOperator_withoutType() {
ParserTestCase.parse4("parseCompilationUnitMember", <Object> [emptyCommentAndMetadata()], "operator +(bool x, bool y) => x | y;", [ParserErrorCode.TOP_LEVEL_OPERATOR]);
}
@@ -8337,6 +8349,22 @@ class ErrorParserTest extends ParserTestCase {
final __test = new ErrorParserTest();
runJUnitTest(__test, __test.test_staticTopLevelDeclaration_variable);
});
+ _ut.test('test_switchHasCaseAfterDefaultCase', () {
+ final __test = new ErrorParserTest();
+ runJUnitTest(__test, __test.test_switchHasCaseAfterDefaultCase);
+ });
+ _ut.test('test_switchHasCaseAfterDefaultCase_repeated', () {
+ final __test = new ErrorParserTest();
+ runJUnitTest(__test, __test.test_switchHasCaseAfterDefaultCase_repeated);
+ });
+ _ut.test('test_switchHasMultipleDefaultCases', () {
+ final __test = new ErrorParserTest();
+ runJUnitTest(__test, __test.test_switchHasMultipleDefaultCases);
+ });
+ _ut.test('test_switchHasMultipleDefaultCases_repeated', () {
+ final __test = new ErrorParserTest();
+ runJUnitTest(__test, __test.test_switchHasMultipleDefaultCases_repeated);
+ });
_ut.test('test_topLevelOperator_withType', () {
final __test = new ErrorParserTest();
runJUnitTest(__test, __test.test_topLevelOperator_withType);

Powered by Google App Engine
This is Rietveld 408576698