Issue 9845. Compare runtime types using ==.

Issue 9845. Compare runtime types using ==.
https://code.google.com/p/dart/issues/detail?id=9845

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21649

[Brian Wilkerson, 2013-04-17 18:59:42]

LGTM

https://codereview.chromium.org/14205011/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java
(right):

https://codereview.chromium.org/14205011/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/DeclarationResolver.java:211:
AnalysisEngine.getInstance().getLogger().logError(writer.toString());
Seems like it would be better still to just write

 ...logError(writer.toString(), new AnalysisException());

https://codereview.chromium.org/14205011/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/14205011/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/resolver.dart:1030: print(new
AnalysisException());
Didn't this need to be "writer.print(...)"?

https://codereview.chromium.org/14205011/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/resolver.dart:1519: ASTNode parent15
= node.parent;
Enhancement request: It would be nice if we could remove local variables from
whatever data structure they're being added to when we leave a method so that we
don't have to have unique names across methods.

[scheglov, 2013-04-17 19:07:16]

Committed patchset #1 manually as r21649 (presubmit successful).