Remove typeddata transferable constructors

tests/standalone/typed_data_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing typed data.
 
 // Library tag to be able to run in html test framework.
 library TypedDataTest;
 
 import "package:expect/expect.dart";
@@ skipping 23 matching lines @@
   Expect.equals(0, typed_data.length);
   Expect.equals(0, typed_data.lengthInBytes);
 
   typed_data = new Uint8ClampedList(10);
   Expect.equals(10, typed_data.length);
   for (int i = 0; i < 10; i++) {
     Expect.equals(0, typed_data[i]);
   }
 }
 
-void testCreateExternalClampedUint8TypedData() {
-  List typed_data;
-
-  typed_data = new Uint8ClampedList.transferable(0);
-  Expect.isTrue(typed_data is Uint8ClampedList);
-  Expect.isFalse(typed_data is Uint8List);
-  Expect.equals(0, typed_data.length);
-  Expect.equals(0, typed_data.lengthInBytes);
-
-  typed_data = new Uint8ClampedList.transferable(10);
-  Expect.equals(10, typed_data.length);
-  for (int i = 0; i < 10; i++) {
-    Expect.equals(0, typed_data[i]);
-  }
-
-  typed_data[0] = -1;
-  Expect.equals(0, typed_data[0]);
-
-  for (int i = 0; i < 10; i++) {
-    typed_data[i] = i + 250;
-  }
-  for (int i = 0; i < 10; i++) {
-    Expect.equals(i + 250 > 255 ? 255 : i + 250, typed_data[i]);
-  }
-}

[siva, 2013/04/15 18:09:05]

I am wondering if we should move this test to
dart_api_impl_test.cc by creating an external uint8clampedArray using the API.

Something similar to
TEST_CASE(ExternalUint8ClampedArrayAccess)

[vsm, 2013/04/16 21:01:57]

This sounds like a good idea.  Can someone on the VM team followup on this?

On 2013/04/15 18:09:05, siva wrote:

-
 void testTypedDataRange(bool check_throws) {
   Int8List typed_data;
   typed_data = new Int8List(10);
   typed_data[1] = 0;
   Expect.equals(0, typed_data[1]);
   typed_data[2] = -128;
   Expect.equals(-128, typed_data[2]);
   typed_data[3] = 127;
   Expect.equals(127, typed_data[3]);
   // This should eventually throw.
@@ skipping 54 matching lines @@
   typed_data[2] = -129;
   Expect.equals(255, typed_data[1]);
   Expect.equals(0, typed_data[2]);
 }
 
 void testClampedUnsignedTypedDataRange(bool check_throws) {
   testClampedUnsignedTypedDataRangeHelper(new Uint8ClampedList(10),
                                           check_throws);
 }
 
-void testExternalClampedUnsignedTypedDataRange(bool check_throws) {
-  testClampedUnsignedTypedDataRangeHelper(new Uint8ClampedList.transferable(10),
-                                          check_throws);
-}
-
 void testSetRangeHelper(typed_data) {
   List<int> list = [10, 11, 12];
   typed_data.setRange(0, 3, list);
   for (int i = 0; i < 3; i++) {
     Expect.equals(10 + i, typed_data[i]);
   }
 
   typed_data[0] = 20;
   typed_data[1] = 21;
   typed_data[2] = 22;
   list.setRange(0, 3, typed_data);
   for (int i = 0; i < 3; i++) {
     Expect.equals(20 + i, list[i]);
   }
 
   typed_data.setRange(1, 2, const [8, 9]);
   Expect.equals(20, typed_data[0]);
   Expect.equals(8, typed_data[1]);
   Expect.equals(9, typed_data[2]);
 }
 
 void testSetRange() {
   testSetRangeHelper(new Uint8List(3));
-  testSetRangeHelper(new Uint8List.transferable(3));
   testSetRangeHelper(new Uint8ClampedList(3));
-  testSetRangeHelper(new Uint8ClampedList.transferable(3));
 }
 
 void testIndexOutOfRangeHelper(typed_data) {
   List<int> list = const [0, 1, 2, 3];
 
   Expect.throws(() {
     typed_data.setRange(0, 4, list);
   });
 
   Expect.throws(() {
     typed_data.setRange(3, 1, list);
   });
 }
 
 void testIndexOutOfRange() {
   testIndexOutOfRangeHelper(new Uint8List(3));
-  testIndexOutOfRangeHelper(new Uint8List.transferable(3));
   testIndexOutOfRangeHelper(new Uint8ClampedList(3));
-  testIndexOutOfRangeHelper(new Uint8ClampedList.transferable(3));
 }
 
 void testIndexOfHelper(list) {
   for (int i = 0; i < list.length; i++) {
     list[i] = i + 10;
   }
   Expect.equals(0, list.indexOf(10));
   Expect.equals(5, list.indexOf(15));
   Expect.equals(9, list.indexOf(19));
   Expect.equals(-1, list.indexOf(20));
 
   list = new Float32List(10);
   for (int i = 0; i < list.length; i++) {
     list[i] = i + 10.0;
   }
   Expect.equals(0, list.indexOf(10.0));
   Expect.equals(5, list.indexOf(15.0));
   Expect.equals(9, list.indexOf(19.0));
   Expect.equals(-1, list.indexOf(20.0));
 }
 
 void testIndexOf() {
-  testIndexOfHelper(new Uint8List.transferable(10));
+  testIndexOfHelper(new Uint8List(10));
   testIndexOfHelper(new Uint8ClampedList(10));
-  testIndexOfHelper(new Uint8ClampedList.transferable(10));
 }
 
 void testGetAtIndex(TypedData list, num initial_value) {
   var bdata = new ByteData.view(list.buffer);
   for (int i = 0; i < bdata.lengthInBytes; i++) {
     Expect.equals(42, bdata.getUint8(i));
     Expect.equals(42, bdata.getInt8(i));
   }
   for (int i = 0; i < bdata.lengthInBytes-1; i+=2) {
     Expect.equals(10794, bdata.getUint16(i));
@@ skipping 107 matching lines @@
       Expect.throws(() => ints[0] = doubles[0]);
       Expect.throws(() => doubles[0] = ints[0]);
     }
   }
 }
 
 main() {
   for (int i = 0; i < 2000; i++) {
     testCreateUint8TypedData();
     testCreateClampedUint8TypedData();
-    testCreateExternalClampedUint8TypedData();
     testTypedDataRange(false);
     testUnsignedTypedDataRange(false);
     testClampedUnsignedTypedDataRange(false);
-    testExternalClampedUnsignedTypedDataRange(false);
     testSetRange();
     testIndexOutOfRange();
     testIndexOf();
 
     var int8list = new Int8List(128);
     testSetAtIndex(int8list, 42);
     testGetAtIndex(int8list, 42);
 
     var uint8list = new Uint8List(128);
     testSetAtIndex(uint8list, 42);
@@ skipping 26 matching lines @@
     var float32list = new Float32List(32);
     testSetAtIndex(float32list, 1.511366173271439e-13, true);
     testGetAtIndex(float32list, 1.511366173271439e-13);
 
     var float64list = new Float64List(16);
     testSetAtIndex(float64list, 1.4260258159703532e-105, true);
     testGetAtIndex(float64list, 1.4260258159703532e-105);
   }
   testTypedDataRange(true);
   testUnsignedTypedDataRange(true);
-  testExternalClampedUnsignedTypedDataRange(true);
   testViewCreation();
   testWhere();
   testCreationFromList();
 }