Remove typeddata transferable constructors

runtime/lib/typeddata.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
 
-  /* patch */ factory Int8List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Int8List.fromList(List<int> elements) {
     var result = new _Int8Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Int8List.view(ByteBuffer buffer,
                                     [int offsetInBytes = 0, int length]) {
     return new _Int8ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalInt8Array _newTransferable(int length) {
     return new _ExternalInt8Array(length);
   }
 }
 
 
 patch class Uint8List {
   /* patch */ factory Uint8List(int length) {
     return new _Uint8Array(length);
   }
 
-  /* patch */ factory Uint8List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Uint8List.fromList(List<int> elements) {
     var result = new _Uint8Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Uint8List.view(ByteBuffer buffer,
                                      [int offsetInBytes = 0, int length]) {
     return new _Uint8ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalUint8Array _newTransferable(int length) {

[vsm, 2013/04/12 22:54:43]

Are these still needed?  I left them in as they are not public and could
presumably be called directly by the embedder.

[siva, 2013/04/15 18:09:05]

I don't think these are called from the embedder, I would remove these too.

On 2013/04/12 22:54:43, vsm wrote:

[vsm, 2013/04/16 21:01:57]

Done.

     return new _ExternalUint8Array(length);
   }
 }
 
 
 patch class Uint8ClampedList {
   /* patch */ factory Uint8ClampedList(int length) {
     return new _Uint8ClampedArray(length);
   }
 
-  /* patch */ factory Uint8ClampedList.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Uint8ClampedList.fromList(List<int> elements) {
     var result = new _Uint8ClampedArray(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Uint8ClampedList.view(ByteBuffer buffer,
                                             [int offsetInBytes = 0,
                                              int length]) {
     return new _Uint8ClampedArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalUint8ClampedArray _newTransferable(int length) {
     return new _ExternalUint8ClampedArray(length);
   }
 }
 
 
 patch class Int16List {
   /* patch */ factory Int16List(int length) {
     return new _Int16Array(length);
   }
 
-  /* patch */ factory Int16List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Int16List.fromList(List<int> elements) {
     var result = new _Int16Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Int16List.view(ByteBuffer buffer,
                                      [int offsetInBytes = 0, int length]) {
     return new _Int16ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalInt16Array _newTransferable(int length) {
     return new _ExternalInt16Array(length);
   }
 }
 
 
 patch class Uint16List {
   /* patch */ factory Uint16List(int length) {
     return new _Uint16Array(length);
   }
 
-  /* patch */ factory Uint16List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Uint16List.fromList(List<int> elements) {
     var result = new _Uint16Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Uint16List.view(ByteBuffer buffer,
                                       [int offsetInBytes = 0, int length]) {
     return new _Uint16ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalUint16Array _newTransferable(int length) {
     return new _ExternalUint16Array(length);
   }
 }
 
 
 patch class Int32List {
   /* patch */ factory Int32List(int length) {
     return new _Int32Array(length);
   }
 
-  /* patch */ factory Int32List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Int32List.fromList(List<int> elements) {
     var result = new _Int32Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Int32List.view(ByteBuffer buffer,
                                      [int offsetInBytes = 0, int length]) {
     return new _Int32ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalInt32Array _newTransferable(int length) {
     return new _ExternalInt32Array(length);
   }
 }
 
 
 patch class Uint32List {
   /* patch */ factory Uint32List(int length) {
     return new _Uint32Array(length);
   }
 
-  /* patch */ factory Uint32List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Uint32List.fromList(List<int> elements) {
     var result = new _Uint32Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Uint32List.view(ByteBuffer buffer,
                                       [int offsetInBytes = 0, int length]) {
     return new _Uint32ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalUint32Array _newTransferable(int length) {
     return new _ExternalUint32Array(length);
   }
 }
 
 
 patch class Int64List {
   /* patch */ factory Int64List(int length) {
     return new _Int64Array(length);
   }
 
-  /* patch */ factory Int64List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Int64List.fromList(List<int> elements) {
     var result = new _Int64Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Int64List.view(ByteBuffer buffer,
                                      [int offsetInBytes = 0, int length]) {
     return new _Int64ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalInt64Array _newTransferable(int length) {
     return new _ExternalInt64Array(length);
   }
 }
 
 
 patch class Uint64List {
   /* patch */ factory Uint64List(int length) {
     return new _Uint64Array(length);
   }
 
-  /* patch */ factory Uint64List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Uint64List.fromList(List<int> elements) {
     var result = new _Uint64Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Uint64List.view(ByteBuffer buffer,
                                       [int offsetInBytes = 0, int length]) {
     return new _Uint64ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalUint64Array _newTransferable(int length) {
     return new _ExternalUint64Array(length);
   }
 }
 
 
 patch class Float32List {
   /* patch */ factory Float32List(int length) {
     return new _Float32Array(length);
   }
 
-  /* patch */ factory Float32List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Float32List.fromList(List<double> elements) {
     var result = new _Float32Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Float32List.view(ByteBuffer buffer,
                                        [int offsetInBytes = 0, int length]) {
     return new _Float32ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalFloat32Array _newTransferable(int length) {
     return new _ExternalFloat32Array(length);
   }
 }
 
 
 patch class Float64List {
   /* patch */ factory Float64List(int length) {
     return new _Float64Array(length);
   }
 
-  /* patch */ factory Float64List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Float64List.fromList(List<double> elements) {
     var result = new _Float64Array(elements.length);
     for (int i = 0; i < elements.length; i++) result[i] = elements[i];
     return result;
   }
 
   /* patch */ factory Float64List.view(ByteBuffer buffer,
                                        [int offsetInBytes = 0, int length]) {
     return new _Float64ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalFloat64Array _newTransferable(int length) {
     return new _ExternalFloat64Array(length);
   }
 }
 
 patch class Float32x4List {
   /* patch */ factory Float32x4List(int length) {
     return new _Float32x4Array(length);
   }
 
-  /* patch */ factory Float32x4List.transferable(int length) {
-    return _newTransferable(length);
-  }
-
   /* patch */ factory Float32x4List.view(ByteBuffer buffer,
                                          [int offsetInBytes = 0, int length]) {
     return new _Float32x4ArrayView(buffer, offsetInBytes, length);
   }
 
   static _ExternalFloat32x4Array _newTransferable(int length) {
     return new _ExternalFloat32x4Array(length);
   }
 }
 
@@ skipping 17 matching lines @@
   }
 }
 
 
 patch class ByteData {
   /* patch */ factory ByteData(int length) {
     var list = new _Uint8Array(length);
     return new _ByteDataView(list.buffer, 0, length);
   }
 
-  /* patch */ factory ByteData.transferable(int length) {
-    var list = new _Uint8Array.transferable(length);
-    return new _ByteDataView(list.buffer, 0, length);
-  }
-
   /* patch */ factory ByteData.view(ByteBuffer buffer,
                                     [int offsetInBytes = 0, int length]) {
     if (length == null) {
       length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _ByteDataView(buffer, offsetInBytes, length);
   }
 }
 
 
@@ skipping 2791 matching lines @@
     return value;
   }
   return object;
 }
 
 
 void _throwRangeError(int index, int length) {
   String message = "$index must be in the range [0..$length)";
   throw new RangeError(message);
 }