Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Issue 14203017: [CSSMQ] Allow integer values for monochrome media feature. (Closed)

Created:
7 years, 7 months ago by rune
Modified:
7 years, 7 months ago
Reviewers:
apavlov
CC:
blink-reviews, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSSMQ] Allow integer values for monochrome media feature. min/max-monochrome already did. BUG=236334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150415

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added missing # in id selector #

Patch Set 3 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A LayoutTests/fast/media/media-feature-monochrome.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/media-feature-monochrome-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
7 years, 7 months ago (2013-05-14 11:26:45 UTC) #1
apavlov
https://codereview.chromium.org/14203017/diff/1/LayoutTests/fast/media/media-feature-monochrome.html File LayoutTests/fast/media/media-feature-monochrome.html (right): https://codereview.chromium.org/14203017/diff/1/LayoutTests/fast/media/media-feature-monochrome.html#newcode4 LayoutTests/fast/media/media-feature-monochrome.html:4: @media not all and (monochrome: 0) { test::before { ...
7 years, 7 months ago (2013-05-15 07:41:48 UTC) #2
rune
On 2013/05/15 07:41:48, apavlov wrote: > (monochrome: 0) { test::before { content: "PASS"; } } ...
7 years, 7 months ago (2013-05-15 08:49:38 UTC) #3
apavlov
lgtm
7 years, 7 months ago (2013-05-15 08:54:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/14203017/5001
7 years, 7 months ago (2013-05-15 08:54:08 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/css/MediaQueryExp.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-15 08:54:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/14203017/13001
7 years, 7 months ago (2013-05-15 09:21:02 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 13:39:10 UTC) #8
Message was sent while issue was closed.
Change committed as 150415

Powered by Google App Engine
This is Rietveld 408576698