[Android] Create and use .TOC files for jars

[Android] Create and use .TOC files for jars

The native component build creates .TOC files for each of the native
libraries. These files contain the compile-time visible API of the
corresponding library. That is, if something changes in the native
library that could have an effect on linking of dependent libraries,
then that change will be reflected in the .TOC file. Then, these .TOC
files can be used to determine if linking of dependents is required.

This change brings that same magic to Java.

When building a .jar, we also create a .jar.TOC that includes the
signatures for public/protected classes/functions/variables (including
the values for constants since they can be inlined dependents).

When compiling a Java library, use an Md5Checker over the .java files
and the classpaths .jar.TOC (using the .jar if the .TOC isn't available
as is currently the case for prebuilt jars).

BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194080

[nilesh, 2013-04-12 01:09:52]

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py
File build/android/gyp/jar_toc.py (right):

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:6: """ Creates a TOC file from a Java jar.
New line after copyright.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:57: def JavapFilter(line):
newline before def

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:69: md5_stamp = '%s.md5' % toc_path
md5_stamp_path

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:71: if md5_checker.IsStale():
Add comment:
# Update the toc file and timestamp.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:75: md5_checker.Write()
Do this only if isstale

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:81: parser.add_option('--toc-path', help='Output
.jar.TOC path.')
where is options.toc_path used? I see that you compute it based on
options.jar_path

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:56: md5_checker = md5_check.Md5Checker(
please add a few comments for Md5Checker. It will be difficult for someone else
to modify this code.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:59: command=javac_cmd)
please rename the named arguments to:
input_files, input_strings

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:69: md5_checker.Write()
Inside isStale if we do not want to update the timestamp of the md5 file.

[cjhopman, 2013-04-12 23:09:47]

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py
File build/android/gyp/jar_toc.py (right):

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:6: """ Creates a TOC file from a Java jar.
On 2013/04/12 01:09:52, nilesh wrote:
> New line after copyright.

Done.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:57: def JavapFilter(line):
On 2013/04/12 01:09:52, nilesh wrote:
> newline before def

Done.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:69: md5_stamp = '%s.md5' % toc_path
On 2013/04/12 01:09:52, nilesh wrote:
> md5_stamp_path

Done.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:71: if md5_checker.IsStale():
On 2013/04/12 01:09:52, nilesh wrote:
> Add comment:
> # Update the toc file and timestamp.
Done... kind of. Renamed function to UpdateToc(...), how's that?

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:75: md5_checker.Write()
On 2013/04/12 01:09:52, nilesh wrote:
> Do this only if isstale

Done.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/jar_toc.py#...
build/android/gyp/jar_toc.py:81: parser.add_option('--toc-path', help='Output
.jar.TOC path.')
On 2013/04/12 01:09:52, nilesh wrote:
> where is options.toc_path used? I see that you compute it based on
> options.jar_path

It's now used, it should not have been computed from jar_path.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:56: md5_checker = md5_check.Md5Checker(
On 2013/04/12 01:09:52, nilesh wrote:
> please add a few comments for Md5Checker. It will be difficult for someone
else
> to modify this code.

I'm preparing a refactoring of Md5Checker and will add the comments +
arg-renames then. Does that work?

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:59: command=javac_cmd)
On 2013/04/12 01:09:52, nilesh wrote:
> please rename the named arguments to:
> input_files, input_strings 
As above.

https://codereview.chromium.org/14203002/diff/1/build/android/gyp/javac.py#ne...
build/android/gyp/javac.py:69: md5_checker.Write()
On 2013/04/12 01:09:52, nilesh wrote:
> Inside isStale if we do not want to update the timestamp of the md5 file.

Done.

[nilesh, 2013-04-12 23:50:57]

LGTM

[commit-bot: I haz the power, 2013-04-13 00:00:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14203002/8001

[commit-bot: I haz the power, 2013-04-13 02:49:38]

Change committed as 194080