Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 14200004: fix wrong class path (Closed)

Created:
7 years, 8 months ago by simonhong_
Modified:
7 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, alicet1, msw+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix wrong class path of BubbleFrameView. The class name of BubbleFrameView is missing "bubble" in its string. Changed from ui/views/BubbleFrameView to ui/views/bubble/BubbleFrameView. R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195102

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/bubble/bubble_frame_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
simonhong_
Dear msw, Please review this patch. Thank you. Simon.
7 years, 8 months ago (2013-04-15 08:53:28 UTC) #1
tfarina
Please, improve your commit message. Describe what is wrong with the current approach. Thanks,
7 years, 8 months ago (2013-04-15 11:22:25 UTC) #2
simonhong_
Dear tfarina, I updated patch description. Thank you! On 2013/04/15 11:22:25, tfarina wrote: > Please, ...
7 years, 8 months ago (2013-04-15 11:36:26 UTC) #3
tfarina
https://codereview.chromium.org/14200004/diff/1/ui/views/bubble/bubble_frame_view.cc File ui/views/bubble/bubble_frame_view.cc (right): https://codereview.chromium.org/14200004/diff/1/ui/views/bubble/bubble_frame_view.cc#newcode151 ui/views/bubble/bubble_frame_view.cc:151: return kViewClassName; could you keep "ui/views/bubble/BubbleFrameView" here instead of ...
7 years, 8 months ago (2013-04-18 22:15:17 UTC) #4
simonhong_
https://codereview.chromium.org/14200004/diff/1/ui/views/bubble/bubble_frame_view.cc File ui/views/bubble/bubble_frame_view.cc (right): https://codereview.chromium.org/14200004/diff/1/ui/views/bubble/bubble_frame_view.cc#newcode151 ui/views/bubble/bubble_frame_view.cc:151: return kViewClassName; On 2013/04/18 22:15:17, tfarina wrote: > could ...
7 years, 8 months ago (2013-04-18 22:20:58 UTC) #5
msw
LGTM
7 years, 8 months ago (2013-04-18 22:21:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/14200004/6001
7 years, 8 months ago (2013-04-18 22:23:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/14200004/6001
7 years, 8 months ago (2013-04-18 23:56:54 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 08:38:32 UTC) #9
Message was sent while issue was closed.
Change committed as 195102

Powered by Google App Engine
This is Rietveld 408576698