unittest/AssemblerX8632/GPRArith.cpp - Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: unittest/AssemblerX8632/GPRArith.cpp

Issue 1419903002: Subzero: Refactor x86 register definitions to use the alias mechanism. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix assembler unit tests. Fix register names. Code review changes. Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/AssemblerX8632/GPRArith.cpp

diff --git a/unittest/AssemblerX8632/GPRArith.cpp b/unittest/AssemblerX8632/GPRArith.cpp

index 309e345983a11335af157ffba04d609cf3b88431..e6ef73afbf84d6de42a8b4d788b0198dbc8c5d28 100644

--- a/unittest/AssemblerX8632/GPRArith.cpp

+++ b/unittest/AssemblerX8632/GPRArith.cpp

@@ -54,8 +54,7 @@ TEST_F(AssemblerX8632Test, SetCC) {

__ cmp(IceType_i32, GPRRegister::Encoded_Reg_##Src0, \

GPRRegister::Encoded_Reg_##Src1); \

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Dest, Immediate(0)); \

- __ setcc(Cond::Br_##C, \

- RegX8632::getEncodedByteReg(GPRRegister::Encoded_Reg_##Dest)); \

+ __ setcc(Cond::Br_##C, ByteRegister(GPRRegister::Encoded_Reg_##Dest)); \

__ setcc(Cond::Br_##C, dwordAddress(T0)); \

AssembledTest test = assemble(); \

@@ -1756,7 +1755,7 @@ TEST_F(AssemblerX8632Test, Bt) {

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Dst, Immediate(Value0)); \

__ mov(IceType_i32, GPRRegister::Encoded_Reg_##Src, Immediate(Value1)); \

__ bt(GPRRegister::Encoded_Reg_##Dst, GPRRegister::Encoded_Reg_##Src); \

- __ setcc(Cond::Br_b, ByteRegister::Encoded_Reg_al); \

+ __ setcc(Cond::Br_b, ByteRegister::Encoded_8_Reg_al); \

__ And(IceType_i32, GPRRegister::Encoded_Reg_eax, Immediate(0xFFu)); \

AssembledTest test = assemble(); \

« no previous file with comments | « tests_lit/llvm2ice_tests/rng.ll ('k') | unittest/AssemblerX8632/LowLevel.cpp » ('j') | no next file with comments »