url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.

url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2.

To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.

BUG=229660
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195389

[tfarina, 2013-04-19 01:28:52]

Not for review!!!

Nico,

http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/99...

../../url/url_canon_icu.h:54:53: error: [chromium-style] Overriding method must
be marked with OVERRIDE.
                                CanonOutput* output);
                                                    ^
                                                     OVERRIDE

Looks like chrome-plugin is checking url/ while it shouldn't after
https://codereview.chromium.org/14064011?

[Nico, 2013-04-19 02:48:31]

The clang plugin is bundled with the clang compiler package. Plugin changes
aren't active immediately, they're only active after a clang roll with that
change has happened.

I have a clang roll in progress with your change in it (
https://codereview.chromium.org/14169006/ ), but it's currently blocked on
https://codereview.chromium.org/13824006/ making it into blink and a revision of
blink with that change then rolling into chromium (I'd guess that happens some
time early tomorrow).

Sorry for the delay!

[tfarina, 2013-04-19 20:18:23]

Thanks for rolling clang Nico!

Brett, I'm going to put this on CQ!

Please, take a look.

Thanks.

[Nico, 2013-04-19 20:19:17]

On Fri, Apr 19, 2013 at 1:18 PM, <tfarina@chromium.org> wrote:

> Thanks for rolling clang Nico!
>

The clang roll got reverted, see
https://code.google.com/p/chromium/issues/detail?id=233709 I'm
investigating the root cause of that problem first before deciding how to
proceed.


>
> Brett, I'm going to put this on CQ!
>
> Please, take a look.
>
> Thanks.
>
>
https://codereview.chromium.**org/14199009/<https://codereview.chromium.org/1...
>

[brettw, 2013-04-20 04:46:39]

lgtm

[tfarina, 2013-04-20 04:48:11]

Nico's clang rolled in.

Putting this on CQ since Brett's approved. Let's see what chrome-plugin says.

[commit-bot: I haz the power, 2013-04-20 04:48:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/14199009/2001

[commit-bot: I haz the power, 2013-04-20 12:35:48]

Change committed as 195389

[gavinp, 2013-04-20 12:52:41]

The trybots on Mac ASAN failed this, and so did trunk. I rolled this back so we
could keep ASAN coverage this weekend.

[tfarina, 2013-04-20 14:18:35]

Nico, looks like chrome-plugin on mac_asan is checking it:

In file included from ../../url/gurl.h:38:
../../url/url_canon_stdstring.h:79:31: error: [chromium-style] virtual methods
with non-empty bodies shouldn't be declared inline.
  virtual void Resize(int sz) {
                              ^

[Nico, 2013-04-21 01:00:28]

On Sat, Apr 20, 2013 at 7:18 AM, <tfarina@chromium.org> wrote:

> Nico, looks like chrome-plugin on mac_asan is checking it:
>
> In file included from ../../url/gurl.h:38:
> ../../url/url_canon_stdstring.**h:79:31: error: [chromium-style] virtual
> methods
> with non-empty bodies shouldn't be declared inline.
>   virtual void Resize(int sz) {
>                               ^
>

Sigh, asan :-( https://codereview.chromium.org/14305005/ should work around
that issue for now.


>
>
https://chromiumcodereview.**appspot.com/14199009/<https://chromiumcodereview...
>