Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc
diff --git a/chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc b/chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc
index 30586cde5a23f49ae13c5f2f459219e66f88ea5c..44a0710a038b0167eee3f490bc9f6da2756eb4d8 100644
--- a/chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc
+++ b/chrome/browser/geolocation/geolocation_infobar_queue_controller_unittest.cc
@@ -15,38 +15,20 @@
class GeolocationInfoBarQueueControllerTests
: public ChromeRenderViewHostTestHarness {
- public:
- GeolocationInfoBarQueueControllerTests();
-
protected:
- GeolocationPermissionRequestID RequestID(int bridge_id);
-
- private:
- // ChromeRenderViewHostTestHarness:
- virtual void SetUp() OVERRIDE;
-
- content::TestBrowserThread ui_thread_;
-
- DISALLOW_COPY_AND_ASSIGN(GeolocationInfoBarQueueControllerTests);
+ virtual void SetUp() OVERRIDE {
+ ChromeRenderViewHostTestHarness::SetUp();
+ InfoBarService::CreateForWebContents(web_contents());
+ }
+
+ GeolocationPermissionRequestID RequestID(int bridge_id) {
+ return GeolocationPermissionRequestID(
+ web_contents()->GetRenderProcessHost()->GetID(),
+ web_contents()->GetRenderViewHost()->GetRoutingID(),
+ bridge_id);
+ }
};
-GeolocationInfoBarQueueControllerTests::GeolocationInfoBarQueueControllerTests()
- : ui_thread_(content::BrowserThread::UI, base::MessageLoop::current()) {
-}
-
-GeolocationPermissionRequestID
- GeolocationInfoBarQueueControllerTests::RequestID(int bridge_id) {
- return GeolocationPermissionRequestID(
- web_contents()->GetRenderProcessHost()->GetID(),
- web_contents()->GetRenderViewHost()->GetRoutingID(),
- bridge_id);
-}
-
-void GeolocationInfoBarQueueControllerTests::SetUp() {
- ChromeRenderViewHostTestHarness::SetUp();
- InfoBarService::CreateForWebContents(web_contents());
-}
-
class ObservationCountingQueueController :
public GeolocationInfoBarQueueController {
public:

Powered by Google App Engine
This is Rietveld 408576698