Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc
diff --git a/chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc b/chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc
index e0fc9db7bbbf6829f0c103f0b1515b48bbd61859..7a8f0ec5a455faa996a4b853d567fa4a5546cbcd 100644
--- a/chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc
+++ b/chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc
@@ -7,15 +7,11 @@
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "chrome/test/base/testing_profile.h"
-#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/test/test_browser_thread.h"
#include "content/public/test/web_contents_tester.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using content::BrowserThread;
-using content::TestBrowserThread;
using content::WebContents;
using content::WebContentsTester;
using extensions::ExperimentalWebAuthFlow;
@@ -80,14 +76,6 @@ class MockExperimentalWebAuthFlow : public ExperimentalWebAuthFlow {
class ExperimentalWebAuthFlowTest : public ChromeRenderViewHostTestHarness {
protected:
- ExperimentalWebAuthFlowTest()
- : thread_(BrowserThread::UI, &message_loop_) {
- }
-
- virtual void SetUp() {
- ChromeRenderViewHostTestHarness::SetUp();
- }
-
virtual void TearDown() {
// DetachDelegateAndDelete posts a task to clean up |flow_|, so it
// has to be called before
@@ -114,7 +102,6 @@ class ExperimentalWebAuthFlowTest : public ChromeRenderViewHostTestHarness {
flow_base()->AfterUrlLoaded();
}
- TestBrowserThread thread_;
MockDelegate delegate_;
scoped_ptr<MockExperimentalWebAuthFlow> flow_;
};

Powered by Google App Engine
This is Rietveld 408576698