Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: chrome/browser/extensions/activity_log/activity_database_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_database_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_database_unittest.cc b/chrome/browser/extensions/activity_log/activity_database_unittest.cc
index 1060c1e80ab2c1df8bef6f62cfc6a0acd29ee2ef..d53e785c4c1492acc8ba90088c3053a363bbf9e1 100644
--- a/chrome/browser/extensions/activity_log/activity_database_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_database_unittest.cc
@@ -38,14 +38,12 @@
namespace extensions {
class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
- public:
- ActivityDatabaseTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoop::current()),
- db_thread_(BrowserThread::DB, base::MessageLoop::current()),
- file_thread_(BrowserThread::FILE, base::MessageLoop::current()) {}
-
+ protected:
virtual void SetUp() OVERRIDE {
ChromeRenderViewHostTestHarness::SetUp();
+#if defined OS_CHROMEOS
+ test_user_manager_.reset(new chromeos::ScopedTestUserManager());
+#endif
CommandLine command_line(CommandLine::NO_PROGRAM);
profile_ =
Profile::FromBrowserContext(web_contents()->GetBrowserContext());
@@ -56,10 +54,11 @@ class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
switches::kEnableExtensionActivityLogTesting);
}
- virtual ~ActivityDatabaseTest() {
- base::MessageLoop::current()->PostTask(FROM_HERE,
- base::MessageLoop::QuitClosure());
- base::MessageLoop::current()->Run();
+ virtual void TearDown() OVERRIDE {
+#if defined OS_CHROMEOS
+ test_user_manager_.reset();
+#endif
+ ChromeRenderViewHostTestHarness::TearDown();
}
protected:
@@ -67,15 +66,11 @@ class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
Profile* profile_;
private:
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread db_thread_;
- content::TestBrowserThread file_thread_;
-
#if defined OS_CHROMEOS
chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
chromeos::ScopedTestCrosSettings test_cros_settings_;
- chromeos::ScopedTestUserManager test_user_manager_;
+ scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
#endif
};
« no previous file with comments | « chrome/browser/extensions/active_tab_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_log_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698