Issue 14197006: Open input method configuration page in new tab page.

Issue 14197006: Open input method configuration page in new tab page. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka

Modified:
7 years, 8 months ago

Reviewers:
James Hawkins, satorux1

CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Open input method configuration page in new tab page. This cl puts configuration button into input method list and it opens extension's configuration page in NTP. BUG=226922 TEST=Manually checked. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195085

Patch Set 1 #

Patch Set 2 : Fix typo #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/language_options.js	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Satoru, Thank you for your review! Adding OWNERS. Hi James, could you take a owner ...

7 years, 8 months ago (2013-04-18 06:57:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14197006/1

7 years, 8 months ago (2013-04-18 16:46:31 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14197006/18001

7 years, 8 months ago (2013-04-18 18:05:58 UTC) #6

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30229

7 years, 8 months ago (2013-04-18 21:15:18 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14197006/18001

7 years, 8 months ago (2013-04-19 00:10:36 UTC) #8

Message was sent while issue was closed.

Change committed as 195085

Expand Messages | Collapse Messages