Prevents SyzyASAN from instrumenting the 'OnMouseRange' function.

Prevents SyzyASAN from instrumenting the 'OnMouseRange' function.

NOTRY=True
BUG=145293
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195223

[Sébastien Marchand, 2013-04-17 21:40:41]

PTAL.

Siggi, I think we can safely bypass the CQ for this patch ? We're the only one
using it and it'll reduce the crash rate on Friday's canary.

[Sigurður Ásgeirsson, 2013-04-17 21:42:18]

lgtm - I'll land this tomorrow ...

[chrisha, 2013-04-17 21:44:02]

lgtm

[Sigurður Ásgeirsson, 2013-04-18 12:40:58]

Actually, on review, I very much doubt that this will help - alas. The
problem is that the method
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/win/hwnd_...
has a fairly high fan-out and complexity, so even if we omit instrumenting
this method, it's likely that we'll just get accesses to the freed block(s)
one or two methods in.
Note particularly the uses of the delegate_ field.
I can still land this, but I doubt that we'll have a great outcome from the
canary :(.


On Wed, Apr 17, 2013 at 5:42 PM, <siggi@chromium.org> wrote:

> lgtm - I'll land this tomorrow ...
>
>
https://codereview.chromium.**org/14195017/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-04-18 22:17:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/14195017/1

[commit-bot: I haz the power, 2013-04-18 22:17:11]

Presubmit check for 14195017-1 failed and returned exit status 1.

INFO:root:Found 1 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/tools/build/win/win-syzyasan-filter.txt

Presubmit checks took 1.6s to calculate.

[Sébastien Marchand, 2013-04-18 22:18:20]

+Gab for the owner green light.

[gab, 2013-04-19 14:24:33]

lgtm w/ comments below.

Please add
BUG=145293
to the CL description.

PS: You can use
NOTRY=True
in the CL description to use the CQ without try jobs (i.e. presubmit checks
only!) -- no need for someone else to dcommit :)!

Cheers,
Gab

https://codereview.chromium.org/14195017/diff/1/chrome/tools/build/win/win-sy...
File chrome/tools/build/win/win-syzyasan-filter.txt (right):

https://codereview.chromium.org/14195017/diff/1/chrome/tools/build/win/win-sy...
chrome/tools/build/win/win-syzyasan-filter.txt:19: #
https://code.google.com/p/chromium/issues/detail?id=145293
nit: Typically links to bugs in comments use the short version
(http://crbug.com/145293) instead of the full HTTPS URL.

[Sébastien Marchand, 2013-04-19 14:54:26]

We don't need this CL anymore as we're finally not on the canary today. But
thanks for the good tips ! (NOTRY=True)

[Sébastien Marchand, 2013-04-19 15:30:09]

Siggi suggested that I land this CL anyway, in case we run an internal canary
before fixing this bug.

https://codereview.chromium.org/14195017/diff/1/chrome/tools/build/win/win-sy...
File chrome/tools/build/win/win-syzyasan-filter.txt (right):

https://codereview.chromium.org/14195017/diff/1/chrome/tools/build/win/win-sy...
chrome/tools/build/win/win-syzyasan-filter.txt:19: #
https://code.google.com/p/chromium/issues/detail?id=145293
On 2013/04/19 14:24:33, gab wrote:
> nit: Typically links to bugs in comments use the short version
> (http://crbug.com/145293) instead of the full HTTPS URL.

Done.

[commit-bot: I haz the power, 2013-04-19 15:31:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/14195017/12001

[commit-bot: I haz the power, 2013-04-19 17:40:50]

Change committed as 195223