Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt

Issue 1419393005: command_buffer: Make inactive bound uniforms reserve the location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix a cc bug exposed by the implementation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt
index ef4e6629c7e81e56b858c25bbe585693604fee6d..eb2f272431756c44197b62d207dadfb48d76ef12 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt
@@ -104,7 +104,8 @@ New Procedures and Functions
to a program object. Hence it is allowed to bind any name (except a name
starting with "gl_") to an index, including a name that is never used as a
uniform in any shader object. Assigned bindings for uniform variables
- that do not exist or are not active are ignored.
+ that do not exist or are not active are ignored. Using such bindings
+ behaves as if passed location was -1.
It is possible for an application to bind more than one uniform name to
the same location. This is referred to as aliasing. This will only work
@@ -126,4 +127,7 @@ Revision History
7/20/2012 Documented the extension
9/8/2015 Require program link to fail if two statically used uniforms
are bound to the same location.
+ 11/6/2015 Require inactive and non-existing, bound uniform locations
+ to behave like location -1.
+

Powered by Google App Engine
This is Rietveld 408576698