Rename PPAPI Video Stream APIs.

Rename PPAPI Video Stream APIs.
PP_VideoFrame -> PP_VideoFrame_Private
PPB_VideoReader -> PPB_VideoSource_Private
PPB_VideoWriter -> PPB_VideoDestination_Private

IDL, .h and C++ wrapper files are now in /private subdirectories.
Renamed some methods to fit the API names better.
Changed the Source Open method's stream_id param to [in].

BUG=230980
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196595

[juberti, 2013-04-24 23:46:05]

https://codereview.chromium.org/14192054/diff/1/ppapi/api/private/ppb_video_d...
File ppapi/api/private/ppb_video_destination_private.idl (right):

https://codereview.chromium.org/14192054/diff/1/ppapi/api/private/ppb_video_d...
ppapi/api/private/ppb_video_destination_private.idl:21: interface
PPB_VideoDestination_Private {
I think this is reversed - a VideoSource is what emits frames, an a
VideoDestination is what receives frames.

https://codereview.chromium.org/14192054/diff/1/ppapi/api/private/ppb_video_d...
ppapi/api/private/ppb_video_destination_private.idl:62: [in] PP_Var stream_id,
stream_url

https://codereview.chromium.org/14192054/diff/1/ppapi/api/private/ppb_video_s...
File ppapi/api/private/ppb_video_source_private.idl (right):

https://codereview.chromium.org/14192054/diff/1/ppapi/api/private/ppb_video_s...
ppapi/api/private/ppb_video_source_private.idl:60: [in] PP_Var stream_id,
stream_url

[dmichael (off chromium), 2013-04-25 15:34:28]

Would you be willing to run git cl upload again with --similarity=75
(or some number bigger than 50)

It might make it easier to review, since some of your files that were moved &
edited are showing up as "new"

[bbudge, 2013-04-25 16:55:12]

git cl upload was giving me a lot of trouble yesterday. Finally I redid the
whole branch with git patch but somehow the file move info got lost. I'll put it
together again.

[dmichael (off chromium), 2013-04-25 18:15:54]

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
File ppapi/api/private/ppb_video_destination_private.idl (right):

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
ppapi/api/private/ppb_video_destination_private.idl:84: int32_t
ReceiveFrame([in] PP_Resource destination,
I think this should still be SendFrame, but the class name should be VideoSource

(or change the parameters around... these params make sense only for sending a
frame, I think)

[bbudge, 2013-04-25 18:21:12]

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
File ppapi/api/private/ppb_video_destination_private.idl (right):

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
ppapi/api/private/ppb_video_destination_private.idl:84: int32_t
ReceiveFrame([in] PP_Resource destination,
Yeah, this is something that has confused me. From the plugin's point of view,
it's sending a frame. But if we think about a VideoDestination as an object, and
ReceiveFrame as a method, then the destination is receiving a frame.

If I have this backwards and misinterpreted your comment Justin, please correct
me.

[Ronghua Wu (Left Chromium), 2013-04-25 18:22:48]

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
File ppapi/api/private/ppb_video_destination_private.idl (right):

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
ppapi/api/private/ppb_video_destination_private.idl:84: int32_t
ReceiveFrame([in] PP_Resource destination,
On 2013/04/25 18:15:54, dmichael wrote:
> I think this should still be SendFrame, but the class name should be
VideoSource
> 
> (or change the parameters around... these params make sense only for sending a
> frame, I think)

Agree this should be SendFrame or PutFrame not receive.

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
File ppapi/api/private/ppb_video_source_private.idl (right):

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
ppapi/api/private/ppb_video_source_private.idl:80: int32_t EmitFrame([in]
PP_Resource source,
Don't we get frame here instead of "emit"?

[bbudge, 2013-04-25 18:30:08]

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
File ppapi/api/private/ppb_video_source_private.idl (right):

https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
ppapi/api/private/ppb_video_source_private.idl:80: int32_t EmitFrame([in]
PP_Resource source,
This does return a frame, but the VideoSource resource 'emits' it. It all
depends on whether you're thinking about it from the plugin's or the object's
point of view. I searched for some existing terminology but didn't find anything
too compelling. I will defer to the video folks on naming here. Justin?

[juberti, 2013-04-25 18:37:45]

On 2013/04/25 18:30:08, bbudge1 wrote:
>
https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
> File ppapi/api/private/ppb_video_source_private.idl (right):
> 
>
https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
> ppapi/api/private/ppb_video_source_private.idl:80: int32_t EmitFrame([in]
> PP_Resource source,
> This does return a frame, but the VideoSource resource 'emits' it. It all
> depends on whether you're thinking about it from the plugin's or the object's
> point of view. I searched for some existing terminology but didn't find
anything
> too compelling. I will defer to the video folks on naming here. Justin?

Looking at the Web Audio precedent, a VideoDestination would put frames into a
MediaStream, whereas a VideoSource would get frames from a MediaStream. Hence
PutFrame should be on VideoDestination, and GetFrame on VideoSource.

[Ronghua Wu (Left Chromium), 2013-04-25 18:44:07]

On 2013/04/25 18:37:45, juberti wrote:
> On 2013/04/25 18:30:08, bbudge1 wrote:
> >
>
https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
> > File ppapi/api/private/ppb_video_source_private.idl (right):
> > 
> >
>
https://codereview.chromium.org/14192054/diff/14002/ppapi/api/private/ppb_vid...
> > ppapi/api/private/ppb_video_source_private.idl:80: int32_t EmitFrame([in]
> > PP_Resource source,
> > This does return a frame, but the VideoSource resource 'emits' it. It all
> > depends on whether you're thinking about it from the plugin's or the
object's
> > point of view. I searched for some existing terminology but didn't find
> anything
> > too compelling. I will defer to the video folks on naming here. Justin?
> 
> Looking at the Web Audio precedent, a VideoDestination would put frames into a
> MediaStream, whereas a VideoSource would get frames from a MediaStream. Hence
> PutFrame should be on VideoDestination, and GetFrame on VideoSource.

+1

[bbudge, 2013-04-25 19:18:44]

Put to VideoDestination, Get from VideoSource.

[dmichael (off chromium), 2013-04-25 20:11:04]

lgtm, thanks for doing that!

[Ronghua Wu (Left Chromium), 2013-04-25 23:46:02]

lgtm

[commit-bot: I haz the power, 2013-04-25 23:54:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/14192054/25001

[commit-bot: I haz the power, 2013-04-26 00:33:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-26 01:32:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/14192054/25001

[commit-bot: I haz the power, 2013-04-26 03:54:06]

Change committed as 196595