Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 14192016: Move OS_CHROMEOS-specific paths to chromeos/chromeos_paths.cc. (Closed)

Created:
7 years, 8 months ago by Joao da Silva
Modified:
7 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move OS_CHROMEOS-specific paths to chromeos/chromeos_paths.cc. Moving these paths out of chrome/common/chrome_paths.cc makes it possible to get them through the PathService from chromeos/ code without violating layering. For example, the SessionManagerClientStubImpl will be able to get DIR_USER_POLICY_KEYS to simulate the storage of user policy keys. BUG=230349 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195843

Patch Set 1 #

Total comments: 2

Patch Set 2 : Register the new provider, updated DEPS rules #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -80 lines) Patch
M chrome/app/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/default_app_order.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/default_app_order_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/owner_key_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +0 lines, -44 lines 0 comments Download
M chrome/test/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A chromeos/chromeos_paths.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chromeos/chromeos_paths.cc View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Joao da Silva
Please have a look: @satorux: chromeos/ changes @jochen: chrome/ changes Thanks!
7 years, 8 months ago (2013-04-19 09:23:09 UTC) #1
satorux1
chromeos/... lgtm
7 years, 8 months ago (2013-04-19 11:48:20 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/14192016/diff/1/chrome/common/chrome_paths.h File chrome/common/chrome_paths.h (left): https://codereview.chromium.org/14192016/diff/1/chrome/common/chrome_paths.h#oldcode100 chrome/common/chrome_paths.h:100: DIR_CHROMEOS_WALLPAPERS, // Directory where downloaded chromeos why are you ...
7 years, 8 months ago (2013-04-19 11:50:45 UTC) #3
Joao da Silva
https://codereview.chromium.org/14192016/diff/1/chrome/common/chrome_paths.h File chrome/common/chrome_paths.h (left): https://codereview.chromium.org/14192016/diff/1/chrome/common/chrome_paths.h#oldcode100 chrome/common/chrome_paths.h:100: DIR_CHROMEOS_WALLPAPERS, // Directory where downloaded chromeos On 2013/04/19 11:50:46, ...
7 years, 8 months ago (2013-04-19 11:52:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-19 11:54:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/3001
7 years, 8 months ago (2013-04-19 12:47:46 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 13:03:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/3001
7 years, 8 months ago (2013-04-19 13:07:52 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 13:20:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/3001
7 years, 8 months ago (2013-04-19 15:24:21 UTC) #10
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=44112
7 years, 8 months ago (2013-04-19 16:00:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/3001
7 years, 8 months ago (2013-04-19 23:27:49 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 00:04:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/30001
7 years, 8 months ago (2013-04-22 16:11:21 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=42777
7 years, 8 months ago (2013-04-22 16:39:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/27002
7 years, 8 months ago (2013-04-23 11:18:38 UTC) #16
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 12:03:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14192016/27002
7 years, 8 months ago (2013-04-23 14:31:33 UTC) #18
commit-bot: I haz the power
7 years, 8 months ago (2013-04-23 18:08:36 UTC) #19
Message was sent while issue was closed.
Change committed as 195843

Powered by Google App Engine
This is Rietveld 408576698