Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3025)

Unified Diff: build/android/buildbot/bb_run_bot.py

Issue 14192007: Add bot config for Android component builder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_run_bot.py
diff --git a/build/android/buildbot/bb_run_bot.py b/build/android/buildbot/bb_run_bot.py
index ff669a00f0cad8b6bc2fa11b6864dcee4d884638..64fd30ec9e126263e63a17d450cd4802cb118c12 100755
--- a/build/android/buildbot/bb_run_bot.py
+++ b/build/android/buildbot/bb_run_bot.py
@@ -22,7 +22,8 @@ CHROME_SRC = os.path.abspath(
GLOBAL_SLAVE_PROPS = {}
BotConfig = collections.namedtuple(
- 'BotConfig', ['bot_id', 'bash_funs', 'test_obj', 'slave_props'])
+ 'BotConfig',
+ ['bot_id', 'bash_funs', 'test_obj', 'slave_props', 'factory_properties'])
TestConfig = collections.namedtuple('Tests', ['tests', 'extra_args'])
Command = collections.namedtuple(
'Command', ['step_name', 'command', 'testing_cmd'])
@@ -40,6 +41,8 @@ def GetCommands(options, bot_config):
slave_props = dict(GLOBAL_SLAVE_PROPS)
if bot_config.slave_props:
slave_props.update(bot_config.slave_props)
+ if bot_config.factory_properties:
+ options.factory_properties.update(bot_config.factory_properties)
Isaac (away) 2013/04/18 22:35:59 This is not the right code path... factory_proper
Siva Chandra 2013/04/18 22:48:58 'extra_gyp_defines' need to be set in factory prop
property_args = [
'--factory-properties=%s' % json.dumps(options.factory_properties),
@@ -92,36 +95,40 @@ def GetBotStepMap():
# Main builders
B('main-builder-dbg',
['bb_check_webview_licenses', 'bb_compile', 'bb_run_findbugs',
- 'bb_zip_build'], None, None),
+ 'bb_zip_build'], None, None, None),
B('main-builder-rel',
- ['bb_compile', 'bb_zip_build'], None, None),
- B('main-clang-builder', compile_step, None, None),
- B('main-clobber', compile_step, None, None),
+ ['bb_compile', 'bb_zip_build'], None, None, None),
+ B('main-clang-builder', compile_step, None, None, None),
+ B('main-clobber', compile_step, None, None, None),
B('main-tests', std_test_steps, T(std_tests, [flakiness_server]),
- None),
+ None, None),
# Other waterfalls
- B('asan-builder', std_build_steps, None, None),
+ B('asan-builder', std_build_steps, None, None, None),
B('asan-tests', std_test_steps + ['bb_asan_tests_setup'],
- T(std_tests, ['--asan']), None),
+ T(std_tests, ['--asan']), None, None),
B('chromedriver-fyi-tests-dbg', std_test_steps, T(['chromedriver']),
- None),
+ None, None),
B('fyi-builder-dbg',
['bb_check_webview_licenses', 'bb_compile', 'bb_compile_experimental',
- 'bb_run_findbugs', 'bb_zip_build'], None, None),
+ 'bb_run_findbugs', 'bb_zip_build'], None, None, None),
B('fyi-builder-rel',
- ['bb_compile', 'bb_compile_experimental', 'bb_zip_build'], None, None),
- B('fyi-tests', std_test_steps,
- T(std_tests, ['--experimental', flakiness_server]), None),
- B('perf-tests-rel', std_test_steps,
- T([], ['--install=ContentShell']),
+ ['bb_compile', 'bb_compile_experimental', 'bb_zip_build'], None, None,
None),
+ B('fyi-tests', std_test_steps,
+ T(std_tests, ['--experimental', flakiness_server]), None, None),
+ B('fyi-component-builder-dbg', compile_step,
+ T(std_tests, ['--experimental', flakiness_server]), None,
+ {'extra_gyp_defines' : 'component=shared_library'}),
+ B('perf-tests-rel', std_test_steps, T([], ['--install=ContentShell']),
+ None, None),
B('webkit-latest-webkit-tests', std_test_steps,
- T(['webkit_layout', 'webkit']), None),
- B('webkit-latest-contentshell', compile_step, T(['webkit_layout']), None),
+ T(['webkit_layout', 'webkit']), None, None),
+ B('webkit-latest-contentshell', compile_step, T(['webkit_layout']), None,
+ None),
# Generic builder config (for substring match).
- B('builder', std_build_steps, None, None),
+ B('builder', std_build_steps, None, None, None),
]
bot_map = dict((config.bot_id, config) for config in bot_configs)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698