Add bot config for Android component builder.

Add bot config for Android component builder.

BUG=178878
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197262

[Siva Chandra, 2013-04-18 22:17:56]

Per suggestion here, https://chromiumcodereview.appspot.com/14208018/, I am
adding a new bot id for Android component builder. Also, the factory_properties
about the new GYP_DEFINES is also set in bb_rub_bot.py.

The try jobs are running. It does not test the new code, but does a sanity check
of the changed.

[Isaac (away), 2013-04-18 22:35:59]

https://chromiumcodereview.appspot.com/14192007/diff/1/build/android/buildbot...
File build/android/buildbot/bb_run_bot.py (right):

https://chromiumcodereview.appspot.com/14192007/diff/1/build/android/buildbot...
build/android/buildbot/bb_run_bot.py:45:
options.factory_properties.update(bot_config.factory_properties)
This is not the right code path...  factory_properties are properties from the
buildbot factory.  We do not update them here.

[Siva Chandra, 2013-04-18 22:48:58]

https://chromiumcodereview.appspot.com/14192007/diff/1/build/android/buildbot...
File build/android/buildbot/bb_run_bot.py (right):

https://chromiumcodereview.appspot.com/14192007/diff/1/build/android/buildbot...
build/android/buildbot/bb_run_bot.py:45:
options.factory_properties.update(bot_config.factory_properties)
On 2013/04/18 22:35:59, Isaac wrote:
> This is not the right code path...  factory_properties are properties from the
> buildbot factory.  We do not update them here.

'extra_gyp_defines' need to be set in factory properties before they are passed
to bb_baseline_setup below. Where do you suggest I update the factory properties
that are passed as argument to bb_baseline_setup?

[Isaac (away), 2013-04-18 22:50:00]

Then change bb_baseline setup, not factory_properties...

[Siva Chandra, 2013-04-18 23:04:01]

On 2013/04/18 22:50:00, Isaac wrote:
> Then change bb_baseline setup, not factory_properties...

I am confused now. If you look at the buildbot code, the Android ASAN builder in
chromium.fyi and the Android clang builder in chromium.linux already specify
extra_gyp_defines via factory properties in their respective master configs. In
your above comment, are you suggesting that I change bb_baseline_setup so that
it does not extract extra_gyp_defines from factory_properties? I agree
extra_gyp_defines is not a factory property but a build property.  However, the
way existing bots pass it around is via factory_properties.

[Siva Chandra, 2013-04-26 02:06:13]

On 2013/04/18 23:04:01, Siva Chandra wrote:
> On 2013/04/18 22:50:00, Isaac wrote:
> > Then change bb_baseline setup, not factory_properties...
> 
> I am confused now. If you look at the buildbot code, the Android ASAN builder
in
> chromium.fyi and the Android clang builder in chromium.linux already specify
> extra_gyp_defines via factory properties in their respective master configs.
In
> your above comment, are you suggesting that I change bb_baseline_setup so that
> it does not extract extra_gyp_defines from factory_properties? I agree
> extra_gyp_defines is not a factory property but a build property.  However,
the
> way existing bots pass it around is via factory_properties.

PING

[Isaac (away), 2013-04-29 01:57:38]

OK, let's put the extra_gyp_defines property in the build CL and remove that
logic from here.

[Siva Chandra, 2013-04-29 20:09:04]

PTAL

[Isaac (away), 2013-04-30 00:22:08]

lgtm

[commit-bot: I haz the power, 2013-04-30 00:24:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/14192007/14001

[commit-bot: I haz the power, 2013-04-30 04:43:05]

Change committed as 197262