Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14190013: Add option in about:flags to disable Quickoffice component extension (Closed)

Created:
7 years, 8 months ago by Dmitry Polukhin
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, stevenjb+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add option in about:flags to disable Quickoffice component extension Previously it was chrome default flag but it is not enough because we need to disable it on official builds from UI for testing purpose. BUG=234604 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/defaults.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/defaults.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dmitry Polukhin
7 years, 8 months ago (2013-04-25 11:53:46 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-25 12:48:41 UTC) #2
Dmitry Polukhin
jhawkins@ for OWNERS review in chrome/browser/ miket@ for OWNERS review in chrome/browser/extensions/ PTAL
7 years, 8 months ago (2013-04-25 13:36:21 UTC) #3
Dmitry Polukhin
jhawkins@ for OWNERS review in chrome/browser/ miket@ for OWNERS review in chrome/browser/extensions/ PTAL
7 years, 8 months ago (2013-04-25 13:37:22 UTC) #4
miket_OOO
> miket@ for OWNERS review in chrome/browser/extensions/ OWNERS LGTM
7 years, 8 months ago (2013-04-25 15:30:38 UTC) #5
James Hawkins
lgtm
7 years, 8 months ago (2013-04-25 16:38:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/14190013/1
7 years, 8 months ago (2013-04-25 16:42:38 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-25 16:43:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/14190013/1
7 years, 8 months ago (2013-04-25 18:12:23 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 19:16:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 196452

Powered by Google App Engine
This is Rietveld 408576698