Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 14189015: KeyframeAnimation::fetchIntervalEndpointsForProperty could use binary search to lookup keyframes (Closed)

Created:
7 years, 8 months ago by shalamov
Modified:
7 years, 6 months ago
Reviewers:
dstockwell, apavlov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

KeyframeAnimation::fetchIntervalEndpointsForProperty could use binary search to lookup keyframes At the moment KeyframeAnimation::fetchIntervalEndpointsForProperty uses linear search algorithm to find keyframes that are closest to elapsed animation time. Keyframe lookup time could be improved by using binary search. BUG=233489 TEST=Covered by LayoutTests/animations Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152650

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed exact comparison for keyframe values #

Total comments: 4

Patch Set 3 : Rebased to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M Source/core/page/animation/KeyframeAnimation.cpp View 1 2 3 chunks +37 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
apavlov
https://codereview.chromium.org/14189015/diff/1/Source/core/page/animation/KeyframeAnimation.cpp File Source/core/page/animation/KeyframeAnimation.cpp (right): https://codereview.chromium.org/14189015/diff/1/Source/core/page/animation/KeyframeAnimation.cpp#newcode111 Source/core/page/animation/KeyframeAnimation.cpp:111: if (key == fractionalTime) I think this will _rarely_ ...
7 years, 8 months ago (2013-04-22 14:23:02 UTC) #1
shalamov
On 2013/04/22 14:23:02, apavlov wrote: Thanks for comments! > https://codereview.chromium.org/14189015/diff/1/Source/core/page/animation/KeyframeAnimation.cpp#newcode135 > Source/core/page/animation/KeyframeAnimation.cpp:135: for (size_t i ...
7 years, 8 months ago (2013-04-23 11:04:08 UTC) #2
dstockwell
7 years, 7 months ago (2013-04-29 07:46:13 UTC) #3
apavlov
On 2013/04/23 11:04:08, shalamov wrote: > On 2013/04/22 14:23:02, apavlov wrote: > > Thanks for ...
7 years, 7 months ago (2013-04-30 12:48:45 UTC) #4
apavlov
https://codereview.chromium.org/14189015/diff/5001/Source/core/page/animation/KeyframeAnimation.cpp File Source/core/page/animation/KeyframeAnimation.cpp (right): https://codereview.chromium.org/14189015/diff/5001/Source/core/page/animation/KeyframeAnimation.cpp#newcode100 Source/core/page/animation/KeyframeAnimation.cpp:100: size_t backIterIndex = 0; This is making the algorithm ...
7 years, 7 months ago (2013-04-30 13:16:11 UTC) #5
apavlov
@shalamov: ping?
7 years, 6 months ago (2013-06-13 12:14:40 UTC) #6
apavlov
lgtm
7 years, 6 months ago (2013-06-18 10:04:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexander.shalamov@intel.com/14189015/12001
7 years, 6 months ago (2013-06-18 10:04:49 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=13082
7 years, 6 months ago (2013-06-18 10:55:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexander.shalamov@intel.com/14189015/12001
7 years, 6 months ago (2013-06-18 15:17:31 UTC) #10
commit-bot: I haz the power
7 years, 6 months ago (2013-06-18 15:46:38 UTC) #11
Message was sent while issue was closed.
Change committed as 152650

Powered by Google App Engine
This is Rietveld 408576698