Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 14189005: Make Syzygy instrumentation use --debug-friendly switch. (Closed)

Created:
7 years, 8 months ago by chrisha
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make Syzygy instrumentation use --debug-friendly switch. This causes PDBs to be output with more detailed OMAP data, which in turn gives us cleaner stack traces. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/tools/build/win/syzygy_instrument.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chrisha
PTAL.
7 years, 8 months ago (2013-04-18 21:16:52 UTC) #1
Sigurður Ásgeirsson
lgtm
7 years, 8 months ago (2013-04-18 21:20:23 UTC) #2
gab
LGTM, please fix CL description though ("to be output with" makes no sense) :)!
7 years, 8 months ago (2013-04-18 21:20:49 UTC) #3
gab
On 2013/04/18 21:20:49, gab wrote: > LGTM, please fix CL description though ("to be output ...
7 years, 8 months ago (2013-04-18 21:21:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/14189005/1
7 years, 8 months ago (2013-04-18 21:25:02 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 03:49:25 UTC) #6
Message was sent while issue was closed.
Change committed as 195079

Powered by Google App Engine
This is Rietveld 408576698