[SPDY] Incorporate latest framing changes from HTTP2 into SPDY 4 as SPDY 4a2.

[SPDY] Incorporate latest framing changes from HTTP2 into SPDY 4 as SPDY 4a2.
Removes support for SPDY 4a1.

Remove --enable-spdy4 flag for now (until we get test
coverage).

This lands server change 45362310.

BUG=230124
TBR=jam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200342

[akalin, 2013-04-16 23:43:25]

+rch for review (I know we may hold off on landing this)

[Ryan Hamilton, 2013-04-16 23:47:38]

This change looks reasonable, but we need tests for spdy/4, particularly after
the spdy/4a1 crash.

[akalin, 2013-04-16 23:49:09]

On 2013/04/16 23:47:38, Ryan Hamilton wrote:
> This change looks reasonable, but we need tests for spdy/4, particularly after
> the spdy/4a1 crash.

Yeap. If I'm not around when that happens, then someone else can land this for
me.

[akalin, 2013-05-08 18:47:33]

What do you think of changing the NPN string to spdy-4a2-unused, landing this,
and then changing to spdy-4a2 when we have test coverage?

[Ryan Hamilton, 2013-05-08 22:15:49]

https://codereview.chromium.org/14189003/diff/8001/net/http/http_stream_facto...
File net/http/http_stream_factory.cc (right):

https://codereview.chromium.org/14189003/diff/8001/net/http/http_stream_facto...
net/http/http_stream_factory.cc:190: next_protos.push_back("spdy/4a2");
I think I might be more inclined to comment out this line until we get test
coverage.  Or, to remove the --enable-spdy4 flag altogether.

[akalin, 2013-05-15 00:16:08]

PTAL

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
File net/http/http_stream_factory.cc (right):

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
net/http/http_stream_factory.cc:190: next_protos.push_back("spdy/4a2");
On 2013/05/08 22:15:50, Ryan Hamilton wrote:
> I think I might be more inclined to comment out this line until we get test
> coverage.  Or, to remove the --enable-spdy4 flag altogether.

Done.

[akalin, 2013-05-15 18:00:27]

ping!

On 2013/05/15 00:16:08, akalin wrote:
> PTAL
> 
>
https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
> File net/http/http_stream_factory.cc (right):
> 
>
https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
> net/http/http_stream_factory.cc:190: next_protos.push_back("spdy/4a2");
> On 2013/05/08 22:15:50, Ryan Hamilton wrote:
> > I think I might be more inclined to comment out this line until we get test
> > coverage.  Or, to remove the --enable-spdy4 flag altogether.
> 
> Done.

[Ryan Hamilton, 2013-05-15 18:32:48]

lgtm 

FWIW, Your PTAL came in after I had left work for the day yesterday and I was
out of the office this morning.  I hadn't forgotten about this CL.

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
File net/http/http_stream_factory.h (right):

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
net/http/http_stream_factory.h:251: static void EnableNpnSpdy4a2();
Totally your cal.  I'm happy for you to keep this method around, and just not
called (Because you removed the option).  But either way.

[akalin, 2013-05-15 18:49:59]

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
File net/http/http_stream_factory.h (right):

https://chromiumcodereview.appspot.com/14189003/diff/8001/net/http/http_strea...
net/http/http_stream_factory.h:251: static void EnableNpnSpdy4a2();
On 2013/05/15 18:32:48, Ryan Hamilton wrote:
> Totally your cal.  I'm happy for you to keep this method around, and just not
> called (Because you removed the option).  But either way.

Meh, I can always resurrect it from source control. I like keeping dead code
out. :)

[commit-bot: I haz the power, 2013-05-15 18:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/14189003/17001

[commit-bot: I haz the power, 2013-05-15 18:59:11]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[akalin, 2013-05-15 19:06:00]

TBR jam for chrome/ stuff

[commit-bot: I haz the power, 2013-05-15 19:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akalin@chromium.org/14189003/17001

[commit-bot: I haz the power, 2013-05-15 20:42:40]

Change committed as 200342