Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: content/renderer/render_view_impl.cc

Issue 14188060: Change decidePolicyForNavigation() to takea WebDataSource::ExtraData (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 197024)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -2848,9 +2848,9 @@
}
WebNavigationPolicy RenderViewImpl::decidePolicyForNavigation(
- WebFrame* frame, WebDataSource* dataSource, const WebURLRequest& request,
- WebNavigationType type, WebNavigationPolicy default_policy,
- bool is_redirect) {
+ WebFrame* frame, WebDataSource::ExtraData* extraData,
+ const WebURLRequest& request, WebNavigationType type,
+ WebNavigationPolicy default_policy, bool is_redirect) {
if (request.url() != GURL(kSwappedOutURL) &&
GetContentClient()->renderer()->HandleNavigation(frame, request, type,
default_policy,
@@ -2892,8 +2892,7 @@
// A content initiated navigation may have originated from a link-click,
// script, drag-n-drop operation, etc.
- bool is_content_initiated =
- DocumentState::FromDataSource(dataSource)->
+ bool is_content_initiated = static_cast<DocumentState*>(extraData)->
navigation_state()->is_content_initiated();
// Experimental:
@@ -3048,7 +3047,8 @@
WebNavigationPolicy RenderViewImpl::decidePolicyForNavigation(
WebFrame* frame, const WebURLRequest& request, WebNavigationType type,
WebNavigationPolicy default_policy, bool is_redirect) {
- return decidePolicyForNavigation(frame, frame->provisionalDataSource(),
+ return decidePolicyForNavigation(frame,
+ frame->provisionalDataSource()->extraData(),
request, type, default_policy, is_redirect);
}
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | webkit/tools/test_shell/test_webview_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698