Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14188044: Avoid double-InitCache() in SimpleDoomBetween test, leak (Closed)

Created:
7 years, 8 months ago by pasko-google - do not use
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Avoid double-InitCache() in SimpleDoomBetween test, leak Quick fix. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/disk_cache/backend_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pasko-google - do not use
7 years, 8 months ago (2013-04-19 15:49:22 UTC) #1
gavinp
lgtm
7 years, 8 months ago (2013-04-19 15:55:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14188044/1
7 years, 8 months ago (2013-04-19 16:01:28 UTC) #3
felipeg
LGTM
7 years, 8 months ago (2013-04-19 16:46:09 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 17:40:02 UTC) #5
Message was sent while issue was closed. 
Change committed as 195222

Powered by Google App Engine
This is Rietveld 408576698