Issue 14188035: Pass error code for drive::JobListObserver::OnJobDone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14188035: Pass error code for drive::JobListObserver::OnJobDone(). (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Pass error code for drive::JobListObserver::OnJobDone(). Some clients need to distiniguish successful return and failure, for example, to show different notification icon. BUG=128079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195160

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	chrome/browser/chromeos/drive/drive_scheduler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/job_list_interface.h	View	2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

kinaba

ptal Implementation for the notification is to come in the next patch: https://codereview.chromium.org/14367010/. As of ...

7 years, 8 months ago (2013-04-19 06:17:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14188035/1

7 years, 8 months ago (2013-04-19 09:53:17 UTC) #3

Message was sent while issue was closed.

Change committed as 195160