[chromedriver] Fix bug in command for GetElementValueOfCSSProperty.

[chromedriver] Fix bug in command for GetElementValueOfCSSProperty.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194971

[kkania, 2013-04-18 00:38:52]

lgtm

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
File chrome/test/chromedriver/element_commands.cc (right):

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_commands.cc:418: return Status(kUnknownError,
"missing 'name'");
propertyName

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
File chrome/test/chromedriver/element_util.cc (right):

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_util.cc:324: const std::string& frame,
i think it would make sense for the webview to be the first arg, unless it's
already been established convention that frame does

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_util.cc:339: return Status(kUnknownError, "fail
to parse value of GET_EFFECTIVE_STYLE");
failed

[chrisgao (Use stgao instead), 2013-04-18 01:39:48]

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
File chrome/test/chromedriver/element_commands.cc (right):

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_commands.cc:418: return Status(kUnknownError,
"missing 'name'");
On 2013/04/18 00:38:52, kkania wrote:
> propertyName

Done.

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
File chrome/test/chromedriver/element_util.cc (right):

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_util.cc:324: const std::string& frame,
On 2013/04/18 00:38:52, kkania wrote:
> i think it would make sense for the webview to be the first arg, unless it's
> already been established convention that frame does
Fix in the established convention here.

https://codereview.chromium.org/14188022/diff/1/chrome/test/chromedriver/elem...
chrome/test/chromedriver/element_util.cc:339: return Status(kUnknownError, "fail
to parse value of GET_EFFECTIVE_STYLE");
On 2013/04/18 00:38:52, kkania wrote:
> failed

Done.

[commit-bot: I haz the power, 2013-04-18 06:05:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14188022/13001

[commit-bot: I haz the power, 2013-04-18 06:25:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-18 15:50:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14188022/13001

[commit-bot: I haz the power, 2013-04-18 18:23:30]

Change committed as 194971