examples/pdf_viewer/BUILD.gn - Issue 1418653002: Synchronize GN build configuration with Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: examples/pdf_viewer/BUILD.gn

Issue 1418653002: Synchronize GN build configuration with Chrome (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Use public_deps instead of deps Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: examples/pdf_viewer/BUILD.gn

diff --git a/examples/pdf_viewer/BUILD.gn b/examples/pdf_viewer/BUILD.gn

index 60243285a23e856438120065aa4ace6d79f0a912..495d2499cbcfdb9da62c9ada01a0b78e742f51c9 100644

--- a/examples/pdf_viewer/BUILD.gn

+++ b/examples/pdf_viewer/BUILD.gn

@@ -21,5 +21,6 @@ mojo_native_application("pdf_viewer") {

"//mojo/services/network/interfaces",

"//mojo/services/view_manager/cpp",

"//third_party/pdfium",

+ "//v8:v8",

jamesr 2015/10/21 00:32:10 you mean "//v8" is this new? i don't see an updat

Petr Hosek 2015/10/21 02:23:42 Done.

]

}