build_overrides/README.md - Issue 1418653002: Synchronize GN build configuration with Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build_overrides/README.md

Issue 1418653002: Synchronize GN build configuration with Chrome (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Use public_deps instead of deps Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Build overrides in GN

	2

	3 This directory is used to allow different products to customize settings

	4 for repos that are DEPS'ed in or shared.

	5

	6 For example: V8 could be built on its own (in a "standalone" configuration),

	7 and it could be built as part of Chromium. V8 might define a top-level

	8 target, //v8:d8 (a simple executable), that should only be built in the

	9 standalone configuration. To figure out whether or not it should be

	10 in a standalone configuration, v8 can create a file, build_overrides/v8.gni,

	11 that contains a variable, `build_standalone_d8 = true`.

	12 and import it (as import("//build_overrides/v8.gni") from its top-level

	13 BUILD.gn file.

	14

	15 Chromium, on the other hand, might not need to build d8, and so it would

	16 create its own build_overrides/v8.gni file, and in it set

	17 `build_standalone_d8 = false`.

	18

	19 The two files should define the same set of variables, but the values can

	20 vary as appropriate to the needs of the two different builds.

OLD	NEW