chrome/android/java/res/values/dimens.xml - Issue 141853007: Update the AppBannerView appearance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 141853007: Update the AppBannerView appearance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Making code ugly for findbugs Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index 49eea2e6cd07b1f96ec2499fa8fb1f0c673fcc1c..13cfde5bbd1aa0b1339fddf87723ccb4d7bb2019 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -39,17 +39,28 @@

- <dimen name="app_banner_max_width">570dp</dimen>

- <dimen name="app_banner_margin_full">8dp</dimen>

- <dimen name="app_banner_margin_bottom">0dp</dimen>

- <dimen name="app_banner_button_height">24dp</dimen>

- <dimen name="app_banner_button_padding_sides">8dp</dimen>

+ <dimen name="app_banner_max_width">424dp</dimen>

+ <dimen name="app_banner_margin_sides">8dp</dimen>

+ <dimen name="app_banner_margin_bottom">8dp</dimen>

+ <dimen name="app_banner_padding">8dp</dimen>

+ <dimen name="app_banner_padding_content">4dp</dimen>

+ <dimen name="app_banner_button_text_size">14sp</dimen>

+ <dimen name="app_banner_button_height">28dp</dimen>

+ <dimen name="app_banner_button_margin_top">8dp</dimen>

+ <dimen name="app_banner_button_margin_start">8dp</dimen>

+ <dimen name="app_banner_button_padding_sides">12dp</dimen>

- <dimen name="app_banner_text_margin_top">0dp</dimen>

- <dimen name="app_banner_text_line_spacing">8dp</dimen>

- <dimen name="app_banner_logo_height">20dp</dimen>

- <dimen name="app_banner_logo_margin_bottom">4dp</dimen>

- <dimen name="app_banner_star_height">12dp</dimen>

+ <dimen name="app_banner_title_text_size">20sp</dimen>

+ <dimen name="app_banner_title_margin_top">0dp</dimen>

+ <dimen name="app_banner_title_margin_bottom">8dp</dimen>

+ <dimen name="app_banner_logo_height">22dp</dimen>

+ <dimen name="app_banner_logo_margin_bottom">3dp</dimen>

+ <dimen name="app_banner_star_height">16dp</dimen>

</resources>