Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 14185002: Move browser and url to WebContents from Tab. (Closed)

Created:
7 years, 8 months ago by achuithb
Modified:
7 years, 8 months ago
Reviewers:
dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Move browser and url to WebContents from Tab. BUG=None TEST=unit tests NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/tab.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/web_contents.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Hopefully this change is not controversial.
7 years, 8 months ago (2013-04-11 23:52:59 UTC) #1
dtu
lgtm
7 years, 8 months ago (2013-04-12 00:08:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/14185002/1
7 years, 8 months ago (2013-04-12 00:48:13 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-12 00:48:32 UTC) #4
Message was sent while issue was closed.
Change committed as 193811

Powered by Google App Engine
This is Rietveld 408576698