Translate: browser test for Chrome Translate in an isolated world

chrome/browser/translate/translate_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 31 matching lines @@
 
 };  // namespace
 
 class TranslateBrowserTest : public InProcessBrowserTest {
  public:
   TranslateBrowserTest()
       : https_server_(net::SpawnedTestServer::TYPE_HTTPS,
                       SSLOptions(SSLOptions::CERT_OK),
                       base::FilePath(kTranslateRoot)) {}
 
-  virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
     ASSERT_TRUE(https_server_.Start());
+    // Setup altenate security-origin for testing in order to allow XHR against

[palmer, 2013/08/01 21:22:38]

Typos: "alternate", "security origin" (or just "origin")

[Takashi Toyoshima, 2013/08/02 04:40:19]

Done.

[Takashi Toyoshima, 2013/08/02 04:40:19]

Done.

+    // local test server. Note that this flag shows a confirm infobar in tests.
+    GURL origin = GetSecureURL("");
+    command_line->AppendSwitchASCII(switches::kTranslateSecurityOrigin,
+                                    origin.spec());
   }
 
  protected:
   GURL GetNonSecureURL(const std::string& path) const {
     std::string prefix(kNonSecurePrefix);
     return embedded_test_server()->GetURL(prefix + path);
   }
 
   GURL GetSecureURL(const std::string& path) const {
     std::string prefix(kSecurePrefix);
     return https_server_.GetURL(prefix + path);
   }
 
+  TranslateInfoBarDelegate* GetExistingTranslateInfoBarDelegate() {
+    if (!infobar_service_) {
+      content::WebContents* web_contents =
+          browser()->tab_strip_model()->GetActiveWebContents();
+      if (web_contents)
+        infobar_service_ = InfoBarService::FromWebContents(web_contents);
+    }
+    if (!infobar_service_) {
+      EXPECT_TRUE(false) << "infobar service is not available";
+      return NULL;
+    }
+
+    TranslateInfoBarDelegate* delegate = NULL;
+    for (size_t i = 0; i < infobar_service_->infobar_count(); ++i) {
+      // Check if the shown infobar is a confirm infobar coming from the
+      // |kTranslateSecurityOrigin| flag specified in SetUpCommandLine().
+      // This infobar appears in all tests of TranslateBrowserTest and can be
+      // ignored here.
+      ConfirmInfoBarDelegate* confirm =
+          infobar_service_->infobar_at(i)->AsConfirmInfoBarDelegate();
+      if (confirm)
+        continue;
+
+      TranslateInfoBarDelegate* translate =
+        infobar_service_->infobar_at(i)->AsTranslateInfoBarDelegate();
+      if (translate) {
+        EXPECT_FALSE(delegate) << "multiple infobars are shown unexpectedly";
+        delegate = translate;
+        continue;
+      }
+
+      // Other infobar should not be shown.
+      EXPECT_TRUE(delegate);
+    }
+    return delegate;
+  }
+
  private:
   net::SpawnedTestServer https_server_;
+  InfoBarService* infobar_service_;
 
   typedef net::SpawnedTestServer::SSLOptions SSLOptions;
 
   DISALLOW_COPY_AND_ASSIGN(TranslateBrowserTest);
 };
 
-// TODO(toyoshim): This test should be changed to work in an isolated world.
-// See also http://crbug.com/164547 .
-IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, DISABLED_Translate) {
+IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, TranslateInIsolatedWorld) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
+  net::TestURLFetcherFactory factory;
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
-  content::WebContents* web_contents =
-      browser()->tab_strip_model()->GetActiveWebContents();
-  ASSERT_TRUE(web_contents);
-
-  net::TestURLFetcherFactory factory;
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 
   // Setup infobar observer.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
   content::WindowedNotificationObserver infobar(
       chrome::NOTIFICATION_TAB_CONTENTS_INFOBAR_ADDED,
       content::NotificationService::AllSources());
 
   // Setup page title observer.
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  ASSERT_TRUE(web_contents);
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit non-secure page which is going to be translated.
   ui_test_utils::NavigateToURL(browser(), GetNonSecureURL(kFrenchTestPath));
 
   // Wait for Chrome Translate infobar.
   infobar.Wait();
 
   // Perform Chrome Translate.
-  ASSERT_EQ(1U, infobar_service->infobar_count());
-  TranslateInfoBarDelegate* translate =
-      infobar_service->infobar_at(0)->AsTranslateInfoBarDelegate();
+  translate = GetExistingTranslateInfoBarDelegate();
   ASSERT_TRUE(translate);
   translate->Translate();
 
   // Hook URLFetcher for element.js.
   GURL script1_url = GetSecureURL(kMainScriptPath);
   GURL script2_url = GetSecureURL(kElementMainScriptPath);
   std::string element_js = "main_script_url = '" + script1_url.spec() + "';\n";
   element_js += "element_main_script_url = '" + script2_url.spec() + "';\n";
   element_js +=
     "google = { 'translate' : { 'TranslateService' : function() { return {\n"
@@ skipping 25 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTag) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit a test page.
   ui_test_utils::NavigateToURL(
       browser(),
       GetNonSecureURL(kRefreshMetaTagTestPath));
 
   // Wait for the page title is changed after the test finished.
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest,
                        IgnoreRefreshMetaTagInCaseInsensitive) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit a test page.
   ui_test_utils::NavigateToURL(
       browser(),
       GetNonSecureURL(kRefreshMetaTagCaseInsensitiveTestPath));
 
   // Wait for the page title is changed after the test finished.
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
+// TODO(toyoshim): Refactoring this test, too.

[palmer, 2013/08/01 21:22:38]

Typo: "Refactor" (it's a command to yourself)

[Takashi Toyoshima, 2013/08/02 04:40:19]

Oops. This was a memo when I'm doing this change.
So this is not just a type, but a bug which should be removed...
Now, I removed this TODO line,

 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, IgnoreRefreshMetaTagAtOnload) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit a test page.
   ui_test_utils::NavigateToURL(
       browser(),
       GetNonSecureURL(kRefreshMetaTagAtOnloadTestPath));
 
   // Wait for the page title is changed after the test finished.
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocation) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit a test page.
   ui_test_utils::NavigateToURL(
       browser(),
       GetNonSecureURL(kUpdateLocationTestPath));
 
   // Wait for the page title is changed after the test finished.
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }
 
 IN_PROC_BROWSER_TEST_F(TranslateBrowserTest, UpdateLocationAtOnload) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
 
+  // Check if there is no Translate infobar.
+  TranslateInfoBarDelegate* translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
+
+  // Setup page title observer.
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(web_contents);
-
-  // Check infobar count.
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents);
-  ASSERT_TRUE(infobar_service);
-  EXPECT_EQ(0U, infobar_service->infobar_count());
-
-  // Setup page title observer.
   content::TitleWatcher watcher(web_contents, ASCIIToUTF16("PASS"));
   watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL"));
 
   // Visit a test page.
   ui_test_utils::NavigateToURL(
       browser(),
       GetNonSecureURL(kUpdateLocationAtOnloadTestPath));
 
   // Wait for the page title is changed after the test finished.
   const string16 result = watcher.WaitAndGetTitle();
   EXPECT_EQ("PASS", UTF16ToASCII(result));
 
-  // Check there is not infobar.
-  EXPECT_EQ(0U, infobar_service->infobar_count());
+  // Check if there is no Translate infobar.
+  translate = GetExistingTranslateInfoBarDelegate();
+  EXPECT_FALSE(translate);
 }