third_party/WebKit/Source/core/testing/Internals.idl - Issue 1417683004: Media controls refer to less magic state.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/testing/Internals.idl

Issue 1417683004: Media controls refer to less magic state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ...because NeedsRebaseline is not a platform type. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/testing/Internals.cpp ('K') | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 * Copyright (C) 2013 Apple Inc. All rights reserved.	3 * Copyright (C) 2013 Apple Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 339 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
350 ClientRectList outlineRects(Element element);	350 ClientRectList outlineRects(Element element);

351 void setCapsLockState(boolean enabled);	351 void setCapsLockState(boolean enabled);

352 void setSelectionPaintingWithoutSelectionGapsEnabled(boolean enabled);	352 void setSelectionPaintingWithoutSelectionGapsEnabled(boolean enabled);

353	353

354 // Returns whether the scrollbar was able to be shown or hidden; not all pla tforms	354 // Returns whether the scrollbar was able to be shown or hidden; not all pla tforms

355 // support overlay scrollbars.	355 // support overlay scrollbars.

356 bool setScrollbarVisibilityInScrollableArea(Node node, boolean visible);	356 bool setScrollbarVisibilityInScrollableArea(Node node, boolean visible);

357	357

358 void forceRestrictIFramePermissions();	358 void forceRestrictIFramePermissions();

359 [RaisesException] double monotonicTimeToZeroBasedDocumentTime(double platfor mTime);	359 [RaisesException] double monotonicTimeToZeroBasedDocumentTime(double platfor mTime);

	360

	361 [TypeChecking=Interface] void setMediaElementNetworkState(HTMLMediaElement e lement, double state);
	philipj_slow 2015/10/28 15:14:02 If this stays, s/double/long/ or some other intege If this stays, s/double/long/ or some other integer type. liberato (no reviews please) 2015/10/29 16:10:26 done. the last time i tried to add a non-double t Show quoted text On 2015/10/28 15:14:02, philipj wrote: > If this stays, s/double/long/ or some other integer type. done. the last time i tried to add a non-double to one of the blink idls, it refused to compile with errors in (i think) the v8 bindings. weird.
360 };	362 };

OLD	NEW